Source/devtools/front_end/OverridesSupport.js - Issue 212103004: [DevTools] Show device screen size in DIPs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/devtools/front_end/OverridesSupport.js

Issue 212103004: [DevTools] Show device screen size in DIPs. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: tests Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/devtools/front_end/OverridesSupport.js

diff --git a/Source/devtools/front_end/OverridesSupport.js b/Source/devtools/front_end/OverridesSupport.js

index ea3e5cb99117c2a10e7666e37ad820135dae1adf..a7088a8b3edbf7604b0ce429b72cd3190767c17d 100644

--- a/Source/devtools/front_end/OverridesSupport.js

+++ b/Source/devtools/front_end/OverridesSupport.js

@@ -461,8 +461,8 @@ WebInspector.OverridesSupport.prototype = {

if (!metrics.isValid())

return;

- var dipWidth = Math.round(metrics.width / metrics.deviceScaleFactor);

- var dipHeight = Math.round(metrics.height / metrics.deviceScaleFactor);

+ var dipWidth = Math.round(metrics.width);

+ var dipHeight = Math.round(metrics.height);

var metricsOverrideEnabled = !!(dipWidth && dipHeight);

// Disable override without checks.