Chromium Code Reviews Chromium Code Reviews
Issue 2120913002:
[Editing][Regression] Contenteditable w/ "-webkit-user-select:all" should be editable. (Closed)
Base URL: https://chromium.googlesource.com/chromium/src.git@master| Index: third_party/WebKit/LayoutTests/editing/selection/user-select/user-select-all-contenteditable.html |
| diff --git a/third_party/WebKit/LayoutTests/editing/selection/user-select/user-select-all-contenteditable.html b/third_party/WebKit/LayoutTests/editing/selection/user-select/user-select-all-contenteditable.html |
| new file mode 100644 |
| index 0000000000000000000000000000000000000000..f94fa57e0886568ea31c9b910c46e911a896c24d |
| --- /dev/null |
| +++ b/third_party/WebKit/LayoutTests/editing/selection/user-select/user-select-all-contenteditable.html |
| @@ -0,0 +1,24 @@ |
| +<!doctype HTML> |
| +<script src="../../../resources/testharness.js"></script> |
| +<script src="../../../resources/testharnessreport.js"></script> |
| +<script src="../../assert_selection.js"></script> |
| +<div id="log"></div> |
| +<script> |
| +test(function(){ |
| + assert_selection( |
| + '<div contenteditable="true" id="div" style="-webkit-user-select:all">foo</div>', |
| + selection => { |
| + selection.collapse(selection.document.getElementById('div'), 0); |
|
yosin_UTC9
2016/07/07 08:59:48
Why not put "|" in test sample?
yoichio
2016/07/07 09:03:27
That's because "putting a caret inside the element
yosin_UTC9
2016/07/08 01:15:04
assert_selection() does for you. It is Selection#c
yoichio
2016/07/08 02:30:39
This is not redundant.
assert_selection("foo|bar",
|
| + selection.document.execCommand("insertText", false, "bar"); |
|
yosin_UTC9
2016/07/08 01:15:04
nit: s/"/'/g
Since we make independent from "inse
yoichio
2016/07/08 02:30:39
Done.
yosin_UTC9
2016/07/08 05:21:02
Stable-blocker or not isn't related to review.
We
yoichio
2016/07/08 08:06:22
Done.
|
| + }, |
| + '<div contenteditable="true" id="div" style="-webkit-user-select:all">bar|foo</div>'); |
| + assert_selection( |
| + '<div contenteditable="true">foo<div id="div" style="-webkit-user-select:all">foo</div>bar</div>', |
| + selection => { |
| + selection.collapse(selection.document.getElementById('div'), 0); |
| + selection.document.execCommand("insertText", false, "bar"); |
| + }, |
| + '<div contenteditable="true">foo<div id="div" style="-webkit-user-select:all">bar|foo</div>bar</div>'); |
| + }, |
| +"Confirm user can insert text in -webkit-user-select:all contenteditable element"); |
| +</script> |
