third_party/WebKit/Source/core/dom/Node.cpp - Issue 2120913002: [Editing][Regression] Contenteditable w/ "-webkit-user-select:all" should be editable.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/dom/Node.cpp

Issue 2120913002: [Editing][Regression] Contenteditable w/ "-webkit-user-select:all" should be editable. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: update Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/LayoutTests/editing/selection/user-select/user-select-all-contenteditable.html ('K') | « third_party/WebKit/LayoutTests/editing/selection/user-select/user-select-all-contenteditable.html ('k') | third_party/WebKit/Source/core/editing/SelectionController.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/dom/Node.cpp

diff --git a/third_party/WebKit/Source/core/dom/Node.cpp b/third_party/WebKit/Source/core/dom/Node.cpp

index 84a8cea65e1140ef19992d5e3c884b1fd0ce5c1f..3156272871a30f18e3a53458ba8316e2754519ff 100644

--- a/third_party/WebKit/Source/core/dom/Node.cpp

+++ b/third_party/WebKit/Source/core/dom/Node.cpp

@@ -557,10 +557,6 @@ bool Node::hasEditableStyle(EditableLevel editableLevel, UserSelectAllTreatment

for (const Node& node : NodeTraversal::inclusiveAncestorsOf(*this)) {

if ((node.isHTMLElement() || node.isDocumentNode()) && node.layoutObject()) {

- // Elements with user-select: all style are considered atomic

- // therefore non editable.

- if (nodeIsUserSelectAll(&node) && treatment == UserSelectAllIsAlwaysNonEditable)

- return false;

switch (node.layoutObject()->style()->userModify()) {

case READ_ONLY:

return false;