Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5173)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: cc/resources/resource_provider_unittest.cc

Issue 2120713002: Fix use_image_texture_target inconsistencies (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: cleanup Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« cc/proto/renderer_settings.proto ('K') | « cc/resources/resource_provider.cc ('k') | cc/surfaces/display.cc » ('j') | cc/surfaces/display.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/resources/resource_provider_unittest.cc
diff --git a/cc/resources/resource_provider_unittest.cc b/cc/resources/resource_provider_unittest.cc
index 89aa6eaccef7d9e372fd091fd2f1cdcd296f52c0..d2b392eefeb6a0a9f4c615f4b5220fec4e0d78a3 100644
--- a/cc/resources/resource_provider_unittest.cc
+++ b/cc/resources/resource_provider_unittest.cc
@@ -25,6 +25,7 @@
#include "cc/test/fake_output_surface.h"
#include "cc/test/fake_output_surface_client.h"
#include "cc/test/test_gpu_memory_buffer_manager.h"
+#include "cc/test/test_image_texture_targets_map.h"
#include "cc/test/test_shared_bitmap_manager.h"
#include "cc/test/test_texture.h"
#include "cc/test/test_web_graphics_context_3d.h"
@@ -48,9 +49,6 @@ namespace {
static const bool kUseGpuMemoryBufferResources = false;
static const bool kDelegatedSyncPointsRequired = true;
-static const std::vector<unsigned> kUseImageTextureTargets(
- static_cast<size_t>(gfx::BufferFormat::LAST) + 1,
- GL_TEXTURE_2D);
MATCHER_P(MatchesSyncToken, sync_token, "") {
gpu::SyncToken other;
@@ -469,13 +467,13 @@ class ResourceProviderTest
output_surface_->context_provider(), shared_bitmap_manager_.get(),
gpu_memory_buffer_manager_.get(), main_thread_task_runner_.get(), 0, 1,
kDelegatedSyncPointsRequired, kUseGpuMemoryBufferResources,
- kUseImageTextureTargets);
+ TestImageTextureTargetsMap());
child_resource_provider_ = base::MakeUnique<ResourceProvider>(
child_output_surface_->context_provider(), shared_bitmap_manager_.get(),
child_gpu_memory_buffer_manager_.get(), main_thread_task_runner_.get(),
0, 1,
child_output_surface_->capabilities().delegated_sync_points_required,
- kUseGpuMemoryBufferResources, kUseImageTextureTargets);
+ kUseGpuMemoryBufferResources, TestImageTextureTargetsMap());
}
ResourceProviderTest() : ResourceProviderTest(true) {}
@@ -1456,7 +1454,7 @@ TEST_P(ResourceProviderTest, TransferGLToSoftware) {
child_output_surface->context_provider(),
shared_bitmap_manager_.get(), gpu_memory_buffer_manager_.get(),
nullptr, 0, 1, kDelegatedSyncPointsRequired,
- kUseGpuMemoryBufferResources, kUseImageTextureTargets));
+ kUseGpuMemoryBufferResources, TestImageTextureTargetsMap()));
gfx::Size size(1, 1);
ResourceFormat format = RGBA_8888;
@@ -1972,7 +1970,7 @@ class ResourceProviderTestTextureFilters : public ResourceProviderTest {
child_output_surface->context_provider(),
shared_bitmap_manager.get(), nullptr, nullptr, 0, 1,
kDelegatedSyncPointsRequired, kUseGpuMemoryBufferResources,
- kUseImageTextureTargets));
+ TestImageTextureTargetsMap()));
std::unique_ptr<TextureStateTrackingContext> parent_context_owned(
new TextureStateTrackingContext);
@@ -1988,7 +1986,7 @@ class ResourceProviderTestTextureFilters : public ResourceProviderTest {
parent_output_surface->context_provider(),
shared_bitmap_manager.get(), nullptr, nullptr, 0, 1,
kDelegatedSyncPointsRequired, kUseGpuMemoryBufferResources,
- kUseImageTextureTargets));
+ TestImageTextureTargetsMap()));
gfx::Size size(1, 1);
ResourceFormat format = RGBA_8888;
@@ -2625,7 +2623,7 @@ TEST_P(ResourceProviderTest, ScopedSampler) {
output_surface->context_provider(), shared_bitmap_manager_.get(),
gpu_memory_buffer_manager_.get(), nullptr, 0, 1,
kDelegatedSyncPointsRequired, kUseGpuMemoryBufferResources,
- kUseImageTextureTargets));
+ TestImageTextureTargetsMap()));
gfx::Size size(1, 1);
ResourceFormat format = RGBA_8888;
@@ -2706,7 +2704,7 @@ TEST_P(ResourceProviderTest, ManagedResource) {
output_surface->context_provider(), shared_bitmap_manager_.get(),
gpu_memory_buffer_manager_.get(), nullptr, 0, 1,
kDelegatedSyncPointsRequired, kUseGpuMemoryBufferResources,
- kUseImageTextureTargets));
+ TestImageTextureTargetsMap()));
gfx::Size size(1, 1);
ResourceFormat format = RGBA_8888;
@@ -2751,7 +2749,7 @@ TEST_P(ResourceProviderTest, TextureWrapMode) {
output_surface->context_provider(), shared_bitmap_manager_.get(),
gpu_memory_buffer_manager_.get(), nullptr, 0, 1,
kDelegatedSyncPointsRequired, kUseGpuMemoryBufferResources,
- kUseImageTextureTargets));
+ TestImageTextureTargetsMap()));
gfx::Size size(1, 1);
ResourceFormat format = RGBA_8888;
@@ -2797,7 +2795,7 @@ TEST_P(ResourceProviderTest, TextureHint) {
output_surface->context_provider(), shared_bitmap_manager_.get(),
gpu_memory_buffer_manager_.get(), nullptr, 0, 1,
kDelegatedSyncPointsRequired, kUseGpuMemoryBufferResources,
- kUseImageTextureTargets));
+ TestImageTextureTargetsMap()));
gfx::Size size(1, 1);
ResourceFormat format = RGBA_8888;
@@ -2858,7 +2856,7 @@ TEST_P(ResourceProviderTest, TextureMailbox_SharedMemory) {
output_surface->context_provider(), shared_bitmap_manager_.get(),
gpu_memory_buffer_manager_.get(), main_thread_task_runner_.get(), 0,
1, kDelegatedSyncPointsRequired, kUseGpuMemoryBufferResources,
- kUseImageTextureTargets));
+ TestImageTextureTargetsMap()));
gpu::SyncToken release_sync_token;
bool lost_resource = false;
@@ -2909,7 +2907,7 @@ class ResourceProviderTestTextureMailboxGLFilters
output_surface->context_provider(), shared_bitmap_manager,
gpu_memory_buffer_manager, main_thread_task_runner, 0, 1,
kDelegatedSyncPointsRequired, kUseGpuMemoryBufferResources,
- kUseImageTextureTargets));
+ TestImageTextureTargetsMap()));
unsigned texture_id = 1;
gpu::SyncToken sync_token(gpu::CommandBufferNamespace::GPU_IO, 0,
@@ -3056,7 +3054,7 @@ TEST_P(ResourceProviderTest, TextureMailbox_GLTextureExternalOES) {
output_surface->context_provider(), shared_bitmap_manager_.get(),
gpu_memory_buffer_manager_.get(), nullptr, 0, 1,
kDelegatedSyncPointsRequired, kUseGpuMemoryBufferResources,
- kUseImageTextureTargets));
+ TestImageTextureTargetsMap()));
gpu::SyncToken sync_token(gpu::CommandBufferNamespace::GPU_IO, 0,
gpu::CommandBufferId::FromUnsafeValue(0x12), 0x34);
@@ -3128,7 +3126,7 @@ TEST_P(ResourceProviderTest,
output_surface->context_provider(), shared_bitmap_manager_.get(),
gpu_memory_buffer_manager_.get(), nullptr, 0, 1,
kDelegatedSyncPointsRequired, kUseGpuMemoryBufferResources,
- kUseImageTextureTargets));
+ TestImageTextureTargetsMap()));
gpu::SyncToken sync_token(gpu::CommandBufferNamespace::GPU_IO, 0,
gpu::CommandBufferId::FromUnsafeValue(0x12), 0x34);
@@ -3186,7 +3184,7 @@ TEST_P(ResourceProviderTest, TextureMailbox_WaitSyncTokenIfNeeded_NoSyncToken) {
output_surface->context_provider(), shared_bitmap_manager_.get(),
gpu_memory_buffer_manager_.get(), nullptr, 0, 1,
kDelegatedSyncPointsRequired, kUseGpuMemoryBufferResources,
- kUseImageTextureTargets));
+ TestImageTextureTargetsMap()));
gpu::SyncToken sync_token;
const GLuint64 current_fence_sync = context->GetNextFenceSync();
@@ -3310,7 +3308,7 @@ TEST_P(ResourceProviderTest, TextureAllocation) {
output_surface->context_provider(), shared_bitmap_manager_.get(),
gpu_memory_buffer_manager_.get(), nullptr, 0, 1,
kDelegatedSyncPointsRequired, kUseGpuMemoryBufferResources,
- kUseImageTextureTargets));
+ TestImageTextureTargetsMap()));
gfx::Size size(2, 2);
gfx::Vector2d offset(0, 0);
@@ -3368,7 +3366,7 @@ TEST_P(ResourceProviderTest, TextureAllocationHint) {
output_surface->context_provider(), shared_bitmap_manager_.get(),
gpu_memory_buffer_manager_.get(), nullptr, 0, 1,
kDelegatedSyncPointsRequired, kUseGpuMemoryBufferResources,
- kUseImageTextureTargets));
+ TestImageTextureTargetsMap()));
gfx::Size size(2, 2);
@@ -3426,7 +3424,7 @@ TEST_P(ResourceProviderTest, TextureAllocationHint_BGRA) {
output_surface->context_provider(), shared_bitmap_manager_.get(),
gpu_memory_buffer_manager_.get(), nullptr, 0, 1,
kDelegatedSyncPointsRequired, kUseGpuMemoryBufferResources,
- kUseImageTextureTargets));
+ TestImageTextureTargetsMap()));
gfx::Size size(2, 2);
const ResourceFormat formats[2] = {RGBA_8888, BGRA_8888};
@@ -3487,7 +3485,7 @@ TEST_P(ResourceProviderTest, Image_GLTexture) {
output_surface->context_provider(), shared_bitmap_manager_.get(),
gpu_memory_buffer_manager_.get(), nullptr, 0, 1,
kDelegatedSyncPointsRequired, kUseGpuMemoryBufferResources,
- kUseImageTextureTargets));
+ TestImageTextureTargetsMap()));
id = resource_provider->CreateResource(
size, ResourceProvider::TEXTURE_HINT_IMMUTABLE, format);
@@ -3567,7 +3565,7 @@ TEST_P(ResourceProviderTest, CompressedTextureETC1Allocate) {
output_surface->context_provider(), shared_bitmap_manager_.get(),
gpu_memory_buffer_manager_.get(), nullptr, 0, 1,
kDelegatedSyncPointsRequired, kUseGpuMemoryBufferResources,
- kUseImageTextureTargets));
+ TestImageTextureTargetsMap()));
int texture_id = 123;
ResourceId id = resource_provider->CreateResource(
@@ -3601,7 +3599,7 @@ TEST_P(ResourceProviderTest, CompressedTextureETC1Upload) {
output_surface->context_provider(), shared_bitmap_manager_.get(),
gpu_memory_buffer_manager_.get(), nullptr, 0, 1,
kDelegatedSyncPointsRequired, kUseGpuMemoryBufferResources,
- kUseImageTextureTargets));
+ TestImageTextureTargetsMap()));
int texture_id = 123;
uint8_t pixels[8];
@@ -3660,7 +3658,7 @@ TEST(ResourceProviderTest, TextureAllocationChunkSize) {
output_surface->context_provider(), shared_bitmap_manager.get(),
nullptr, nullptr, 0, kTextureAllocationChunkSize,
kDelegatedSyncPointsRequired, kUseGpuMemoryBufferResources,
- kUseImageTextureTargets));
+ TestImageTextureTargetsMap()));
ResourceId id = resource_provider->CreateResource(
size, ResourceProvider::TEXTURE_HINT_IMMUTABLE, format);
@@ -3678,7 +3676,7 @@ TEST(ResourceProviderTest, TextureAllocationChunkSize) {
output_surface->context_provider(), shared_bitmap_manager.get(),
nullptr, nullptr, 0, kTextureAllocationChunkSize,
kDelegatedSyncPointsRequired, kUseGpuMemoryBufferResources,
- kUseImageTextureTargets));
+ TestImageTextureTargetsMap()));
ResourceId id = resource_provider->CreateResource(
size, ResourceProvider::TEXTURE_HINT_IMMUTABLE, format);
« cc/proto/renderer_settings.proto ('K') | « cc/resources/resource_provider.cc ('k') | cc/surfaces/display.cc » ('j') | cc/surfaces/display.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698