Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(960)

Unified Diff: net/quic/quic_stream_factory.h

Issue 2120703003: QUIC - Race Cert Verification with host resolution if certs are (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Minor optimization, when verifying certs only skip policy checks. Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/quic/quic_stream_factory.h
diff --git a/net/quic/quic_stream_factory.h b/net/quic/quic_stream_factory.h
index 77fb744d66c8b46d69118c805e36db933f5ffb9f..6f5b3d1d7fb1f629a55c90812b160d5701669f6e 100644
--- a/net/quic/quic_stream_factory.h
+++ b/net/quic/quic_stream_factory.h
@@ -186,6 +186,7 @@ class NET_EXPORT_PRIVATE QuicStreamFactory
int idle_connection_timeout_seconds,
bool migrate_sessions_on_network_change,
bool migrate_sessions_early,
+ bool race_cert_verification,
const QuicTagVector& connection_options,
bool enable_token_binding);
~QuicStreamFactory() override;
@@ -352,6 +353,7 @@ class NET_EXPORT_PRIVATE QuicStreamFactory
private:
class Job;
+ class CertVerifierJob;
friend class test::QuicStreamFactoryPeer;
FRIEND_TEST_ALL_PREFIXES(HttpStreamFactoryTest, QuicLossyProxyMarkedAsBad);
@@ -369,6 +371,8 @@ class NET_EXPORT_PRIVATE QuicStreamFactory
typedef std::map<QuicServerId, RequestSet> ServerIDRequestsMap;
typedef std::deque<enum QuicChromiumClientSession::QuicDisabledReason>
DisabledReasonsQueue;
+ typedef std::map<QuicServerId, std::unique_ptr<CertVerifierJob>>
+ CertVerifierJobMap;
enum FactoryStatus {
OPEN, // New streams may be created.
@@ -388,8 +392,10 @@ class NET_EXPORT_PRIVATE QuicStreamFactory
bool OnResolution(const QuicSessionKey& key, const AddressList& address_list);
void OnJobComplete(Job* job, int rv);
+ void OnCertVerifyJobComplete(CertVerifierJob* job, int rv);
bool HasActiveSession(const QuicServerId& server_id) const;
bool HasActiveJob(const QuicServerId& server_id) const;
+ bool HasActiveCertVerifierJob(const QuicServerId& server_id) const;
int CreateSession(const QuicSessionKey& key,
int cert_verify_flags,
std::unique_ptr<QuicServerInfo> quic_server_info,
@@ -411,6 +417,13 @@ class NET_EXPORT_PRIVATE QuicStreamFactory
bool CryptoConfigCacheIsEmpty(const QuicServerId& server_id);
+ // Starts an asynchronous job for cert verification if
+ // |race_cert_verification_| is enabled and if there are cached certs for the
+ // given |server_id|.
+ void StartCertVerifyJob(const QuicServerId& server_id,
+ int cert_verify_flags,
+ const BoundNetLog& net_log);
+
// Initializes the cached state associated with |server_id| in
// |crypto_config_| with the information in |server_info|. Populates
// |connection_id| with the next server designated connection id,
@@ -478,6 +491,8 @@ class NET_EXPORT_PRIVATE QuicStreamFactory
ServerIDRequestsMap job_requests_map_;
RequestMap active_requests_;
+ CertVerifierJobMap active_cert_verifier_jobs_;
+
QuicVersionVector supported_versions_;
// Determine if we should consistently select a client UDP port. If false,
@@ -560,6 +575,9 @@ class NET_EXPORT_PRIVATE QuicStreamFactory
// experiences poor connectivity.
const bool migrate_sessions_early_;
+ // Set if cert verification is to be raced with host resolution.
+ bool race_cert_verification_;
+
// Each profile will (probably) have a unique port_seed_ value. This value
// is used to help seed a pseudo-random number generator (PortSuggester) so
// that we consistently (within this profile) suggest the same ephemeral

Powered by Google App Engine
This is Rietveld 408576698