Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(478)

Unified Diff: net/quic/crypto/proof_verifier_chromium_test.cc

Issue 2120703003: QUIC - Race Cert Verification with host resolution if certs are (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Minor optimization, when verifying certs only skip policy checks. Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/quic/crypto/proof_verifier_chromium_test.cc
diff --git a/net/quic/crypto/proof_verifier_chromium_test.cc b/net/quic/crypto/proof_verifier_chromium_test.cc
index ba881c6285b0fb43b63f5756d43765c8a1e2225f..1866af9905576a2262da2b214b3da64e9d010ba1 100644
--- a/net/quic/crypto/proof_verifier_chromium_test.cc
+++ b/net/quic/crypto/proof_verifier_chromium_test.cc
@@ -587,5 +587,34 @@ TEST_F(ProofVerifierChromiumTest, PKPAndCTBothTested) {
CERT_STATUS_CERTIFICATE_TRANSPARENCY_REQUIRED);
}
+// Tests that the VerifyCertChain verifies certificates.
+TEST_F(ProofVerifierChromiumTest, VerifyCertChain) {
+ scoped_refptr<X509Certificate> test_cert = GetTestServerCertificate();
+ ASSERT_TRUE(test_cert);
+
+ CertVerifyResult dummy_result;
+ dummy_result.verified_cert = test_cert;
+ dummy_result.cert_status = 0;
+
+ MockCertVerifier dummy_verifier;
+ dummy_verifier.AddResultForCert(test_cert.get(), dummy_result, OK);
+
+ ProofVerifierChromium proof_verifier(&dummy_verifier, &ct_policy_enforcer_,
+ &transport_security_state_,
+ ct_verifier_.get());
+
+ std::unique_ptr<DummyProofVerifierCallback> callback(
+ new DummyProofVerifierCallback);
+ QuicAsyncStatus status = proof_verifier.VerifyCertChain(
+ kTestHostname, kTestPort, certs_, verify_context_.get(), &error_details_,
+ &details_, callback.get());
+ ASSERT_EQ(QUIC_SUCCESS, status);
+
+ ASSERT_TRUE(details_.get());
+ ProofVerifyDetailsChromium* verify_details =
+ static_cast<ProofVerifyDetailsChromium*>(details_.get());
+ EXPECT_EQ(0u, verify_details->cert_verify_result.cert_status);
+}
+
} // namespace test
} // namespace net

Powered by Google App Engine
This is Rietveld 408576698