Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Unified Diff: components/cronet/url_request_context_config_unittest.cc

Issue 2120703003: QUIC - Race Cert Verification with host resolution if certs are (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix comments. Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/cronet/url_request_context_config.cc ('k') | net/http/http_network_session.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/cronet/url_request_context_config_unittest.cc
diff --git a/components/cronet/url_request_context_config_unittest.cc b/components/cronet/url_request_context_config_unittest.cc
index 56025cd4246e4122a9d6eedfb9dac42d4a615d29..b9bb00a92d546b9bf229e073cf7c0b8baf7724a7 100644
--- a/components/cronet/url_request_context_config_unittest.cc
+++ b/components/cronet/url_request_context_config_unittest.cc
@@ -47,6 +47,7 @@ TEST(URLRequestContextConfigTest, SetQuicExperimentalOptions) {
"\"idle_connection_timeout_seconds\":300,"
"\"close_sessions_on_ip_change\":true,"
"\"connection_options\":\"TIME,TBBR,REJ\"},"
+ "\"race_cert_verification\":true,"
mef 2016/07/08 13:23:50 I think test below fails because this line is NOT
ramant (doing other things) 2016/07/08 23:13:49 Done.
"\"AsyncDNS\":{\"enable\":true}}",
// Data reduction proxy key.
"",
@@ -101,6 +102,9 @@ TEST(URLRequestContextConfigTest, SetQuicExperimentalOptions) {
EXPECT_TRUE(params->quic_close_sessions_on_ip_change);
EXPECT_FALSE(params->quic_migrate_sessions_on_network_change);
+ // Check race_cert_verification.
+ EXPECT_TRUE(params->quic_race_cert_verification);
+
// Check AsyncDNS resolver is enabled.
EXPECT_TRUE(context->host_resolver()->GetDnsConfigAsValue());
}
« no previous file with comments | « components/cronet/url_request_context_config.cc ('k') | net/http/http_network_session.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698