DevTools: make arrays expandable by default in console

DevTools: make arrays expandable by default in console

BUG=607682
Committed: https://crrev.com/697a783fb10a4ec2777c71d22521820856816a91
Cr-Commit-Position: refs/heads/master@{#404499}

[luoe, 2016-07-07 21:24:28]

Description was changed from

==========
DevTools: make arrays and functions expandable

BUG=607681
==========

to

==========
DevTools: make arrays and functions expandable

BUG=607682
==========

[luoe, 2016-07-07 21:27:23]

luoe@chromium.org changed reviewers:
+ lushnikov@chromium.org

[luoe, 2016-07-07 21:27:24]

Ptal :)

[luoe, 2016-07-07 21:27:51]

Description was changed from

==========
DevTools: make arrays and functions expandable

BUG=607682
==========

to

==========
DevTools: make arrays expandable by default in console

BUG=607682
==========

[lushnikov, 2016-07-08 17:49:27]

lgtm

https://codereview.chromium.org/2120613002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js
(right):

https://codereview.chromium.org/2120613002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js:718:
if (this._message.type === WebInspector.ConsoleMessage.MessageType.DirXML)
Style:
1. curly braces around multiline block
2. do not use "else" if the main "if" branch does return

[luoe, 2016-07-08 17:53:46]

https://codereview.chromium.org/2120613002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js
(right):

https://codereview.chromium.org/2120613002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js:718:
if (this._message.type === WebInspector.ConsoleMessage.MessageType.DirXML)
On 2016/07/08 17:49:27, lushnikov wrote:
> Style:
> 1. curly braces around multiline block
> 2. do not use "else" if the main "if" branch does return

Done.

[luoe, 2016-07-08 17:53:53]

The CQ bit was checked by luoe@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-08 17:54:31]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-08 17:57:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-08 17:57:49]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-gn on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-gn/bui...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  ios-simulator-gn on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-gn/...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[luoe, 2016-07-08 19:09:37]

The CQ bit was checked by luoe@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-08 19:10:22]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-08 20:28:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-08 20:28:42]

Dry run: This issue passed the CQ dry run.

[luoe, 2016-07-08 20:41:43]

The CQ bit was checked by luoe@chromium.org

[luoe, 2016-07-08 20:41:44]

The patchset sent to the CQ was uploaded after l-g-t-m from
lushnikov@chromium.org
Link to the patchset: https://codereview.chromium.org/2120613002/#ps80001
(title: "Rebase + conflict resolution")

[commit-bot: I haz the power, 2016-07-08 20:42:08]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-08 21:48:02]

Description was changed from

==========
DevTools: make arrays expandable by default in console

BUG=607682
==========

to

==========
DevTools: make arrays expandable by default in console

BUG=607682
==========

[commit-bot: I haz the power, 2016-07-08 21:48:03]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-07-08 21:49:47]

Description was changed from

==========
DevTools: make arrays expandable by default in console

BUG=607682
==========

to

==========
DevTools: make arrays expandable by default in console

BUG=607682

Committed: https://crrev.com/697a783fb10a4ec2777c71d22521820856816a91
Cr-Commit-Position: refs/heads/master@{#404499}
==========

[commit-bot: I haz the power, 2016-07-08 21:49:48]

Patchset 5 (id:??) landed as
https://crrev.com/697a783fb10a4ec2777c71d22521820856816a91
Cr-Commit-Position: refs/heads/master@{#404499}

[wOxxOm, 2016-10-29 02:04:28]

This change has broken expansion of HTML elements.

Previously $$('body') array elements were expanded as HTML elements (DOM tree
was shown).
Now $$('body') array elements are expanded as JavaScript objects (properties are
shown).

[wOxxOm, 2016-10-29 02:08:45]

Also, now we can't expand the elements directly by clicking the
collapsed-by-default array in the log.