Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Unified Diff: third_party/WebKit/LayoutTests/inspector/console/console-external-array.html

Issue 2120613002: DevTools: make arrays expandable by default in console (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@tree-expand3
Patch Set: Rebase + conflict resolution Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/inspector/console/console-external-array-expected.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/LayoutTests/inspector/console/console-external-array.html
diff --git a/third_party/WebKit/LayoutTests/inspector/console/console-external-array.html b/third_party/WebKit/LayoutTests/inspector/console/console-external-array.html
index 77571d80f27270c0d36b1b66758f94a30cfb68ef..4c995173392d1e4d68f32cdea4c155a57e70cc39 100644
--- a/third_party/WebKit/LayoutTests/inspector/console/console-external-array.html
+++ b/third_party/WebKit/LayoutTests/inspector/console/console-external-array.html
@@ -4,7 +4,7 @@
<script src="../../http/tests/inspector/console-test.js"></script>
<script>
-function onload()
+function logToConsole()
{
console.log(new Int8Array(10));
console.log(new Int16Array(10));
@@ -23,20 +23,29 @@ function onload()
console.dir(new Uint32Array(10));
console.dir(new Float32Array(10));
console.dir(new Float64Array(10));
-
- runTest();
}
function test()
{
- InspectorTest.dumpConsoleMessages();
- InspectorTest.completeTest();
+ InspectorTest.evaluateInPage("logToConsole()", onLoggedToConsole);
+
+
+ function onLoggedToConsole()
+ {
+ InspectorTest.waitForRemoteObjectsConsoleMessages(onRemoteObjectsLoaded)
+ }
+
+ function onRemoteObjectsLoaded()
+ {
+ InspectorTest.dumpConsoleMessages();
+ InspectorTest.completeTest();
+ }
}
</script>
</head>
-<body onload="onload()">
+<body onload="runTest()">
<p>
Tests that console logging detects external arrays as arrays.
</p>
« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/inspector/console/console-external-array-expected.txt » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698