ui/arc/notification/arc_custom_notification_view.h - Issue 2120593002: arc: Fix custom notification crash on closing

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/arc/notification/arc_custom_notification_view.h

Issue 2120593002: arc: Fix custom notification crash on closing (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ui/arc/notification/arc_custom_notification_view.h

diff --git a/ui/arc/notification/arc_custom_notification_view.h b/ui/arc/notification/arc_custom_notification_view.h

index 4505f269073b647e33cc923565cb95fde32f9b00..6c25b720f4372a31f463015dec24367839672f60 100644

--- a/ui/arc/notification/arc_custom_notification_view.h

+++ b/ui/arc/notification/arc_custom_notification_view.h

@@ -46,9 +46,10 @@ class ArcCustomNotificationView : public views::NativeViewHost,

// ArcCustomNotificationItem::Observer

void OnItemDestroying() override;

void OnItemPinnedChanged() override;

+ void OnItemNotificationSurfaceRemoved() override;

ArcCustomNotificationItem* item_;

- exo::NotificationSurface* const surface_;

+ exo::NotificationSurface* surface_;

// A close button on top of NotificationSurface. Needed because the

// aura::Window of NotificationSurface is added after hosting widget's