Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(438)

Issue 2120523002: The children of non-editable combo boxes, search boxes and text fields should not be hidden (Closed)

Created:
4 years, 5 months ago by nektarios
Modified:
4 years, 5 months ago
Reviewers:
dmazzoni
CC:
aboxhall+watch_chromium.org, chromium-reviews, darin-cc_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, jam, je_julie, nektar+watch_chromium.org, yuzo+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

The children of non-editable combo boxes, search boxes and text fields specified via e.g. aria-owns should not be hidden from platform trees. Children of combo boxes, search boxes and text fields might not always be part of the shadow DOM, especially when no <input> or contentEditable . tags have been usedThey might be a list of combo box items specified via aria-owns. data:text/html,<div role="combobox" aria-owns="list" onKeyDown="this.setAttribute('aria-activedescendant', 'item');">content</div><ul id="list"><li id="item">item</li></ul> BUG=620432 R=dmazzoni@chromium.org TESTED=manually with Jaws NVDA and Voiceover Committed: https://crrev.com/734e21b735b81cc5c8ac04a98e330a9e7f51decd Cr-Commit-Position: refs/heads/master@{#404478}

Patch Set 1 #

Patch Set 2 : Only non-editable text, combo and search boxes can expose their children. #

Patch Set 3 : Changed Blink to check if text boxes are really editable before marking them as such. #

Patch Set 4 : Fixed tests. #

Patch Set 5 : Replaced test expectations. #

Patch Set 6 : Multi-line text fields should drop their children on Android. #

Patch Set 7 : Fixed Mac tests. #

Patch Set 8 : Fixed Mac implementation. #

Patch Set 9 : Fixed datetime field. #

Patch Set 10 : Fixed datetime test on Windows. #

Patch Set 11 : Fixed combo box unit test on Windows. #

Patch Set 12 : Fixed Windows unit tests. #

Patch Set 13 : Fixed Windows browser test. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+85 lines, -48 lines) Patch
M content/browser/accessibility/browser_accessibility.h View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +1 line, -1 line 0 comments Download
M content/browser/accessibility/browser_accessibility.cc View 1 2 3 4 5 6 7 8 9 10 11 2 chunks +18 lines, -1 line 0 comments Download
M content/browser/accessibility/browser_accessibility_android.h View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M content/browser/accessibility/browser_accessibility_android.cc View 1 2 3 4 5 4 chunks +6 lines, -7 lines 0 comments Download
M content/browser/accessibility/browser_accessibility_win.cc View 1 2 3 4 5 6 7 8 9 10 11 7 chunks +12 lines, -17 lines 0 comments Download
M content/browser/accessibility/browser_accessibility_win_unittest.cc View 1 2 3 4 5 6 7 8 9 10 11 5 chunks +13 lines, -14 lines 0 comments Download
M content/test/data/accessibility/aria/aria-autocomplete-expected-win.txt View 1 2 3 1 chunk +4 lines, -0 lines 0 comments Download
M content/test/data/accessibility/aria/aria-searchbox-expected-mac.txt View 1 2 3 4 5 6 1 chunk +1 line, -0 lines 0 comments Download
M content/test/data/accessibility/aria/aria-searchbox-expected-win.txt View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download
M content/test/data/accessibility/aria/aria-searchbox-with-selection-expected-mac.txt View 1 2 3 4 5 6 1 chunk +1 line, -0 lines 0 comments Download
M content/test/data/accessibility/aria/aria-searchbox-with-selection-expected-win.txt View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M content/test/data/accessibility/aria/aria-textbox-expected-mac.txt View 1 2 3 4 5 6 1 chunk +2 lines, -0 lines 0 comments Download
M content/test/data/accessibility/aria/aria-textbox-expected-win.txt View 1 2 3 1 chunk +4 lines, -2 lines 0 comments Download
M content/test/data/accessibility/aria/aria-textbox-with-selection-expected-mac.txt View 1 2 3 4 5 6 1 chunk +5 lines, -0 lines 0 comments Download
M content/test/data/accessibility/aria/aria-textbox-with-selection-expected-win.txt View 1 2 3 4 1 chunk +9 lines, -3 lines 0 comments Download
M content/test/data/accessibility/html/input-datetime-expected-mac.txt View 1 2 3 4 5 6 7 8 1 chunk +2 lines, -0 lines 0 comments Download
M content/test/data/accessibility/html/input-datetime-expected-win.txt View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/accessibility/AXNodeObject.h View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 64 (36 generated)
nektarios
4 years, 5 months ago (2016-07-01 18:32:48 UTC) #1
dmazzoni
lgtm This might affect some tests but definitely looks like the right thing
4 years, 5 months ago (2016-07-01 19:04:42 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2120523002/40001
4 years, 5 months ago (2016-07-01 19:46:17 UTC) #5
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/239180)
4 years, 5 months ago (2016-07-01 20:28:40 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2120523002/60001
4 years, 5 months ago (2016-07-01 21:38:42 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/239235)
4 years, 5 months ago (2016-07-01 22:41:58 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2120523002/80001
4 years, 5 months ago (2016-07-01 22:54:08 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: ios-device-gn on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-gn/builds/30558)
4 years, 5 months ago (2016-07-01 22:59:39 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2120523002/80001
4 years, 5 months ago (2016-07-01 23:18:11 UTC) #19
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/97664)
4 years, 5 months ago (2016-07-02 00:10:52 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2120523002/100001
4 years, 5 months ago (2016-07-02 00:51:15 UTC) #24
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/97743)
4 years, 5 months ago (2016-07-02 01:49:54 UTC) #26
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2120523002/100001
4 years, 5 months ago (2016-07-06 01:22:40 UTC) #28
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/255183)
4 years, 5 months ago (2016-07-06 03:21:50 UTC) #30
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2120523002/120001
4 years, 5 months ago (2016-07-06 17:03:31 UTC) #32
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/255469)
4 years, 5 months ago (2016-07-06 18:38:25 UTC) #34
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2120523002/160001
4 years, 5 months ago (2016-07-06 22:12:19 UTC) #36
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/240786)
4 years, 5 months ago (2016-07-06 23:35:53 UTC) #38
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2120523002/180001
4 years, 5 months ago (2016-07-06 23:46:04 UTC) #41
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/240892)
4 years, 5 months ago (2016-07-07 01:32:17 UTC) #43
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2120523002/200001
4 years, 5 months ago (2016-07-07 14:50:35 UTC) #46
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/241282)
4 years, 5 months ago (2016-07-07 16:12:14 UTC) #48
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2120523002/220001
4 years, 5 months ago (2016-07-07 23:08:54 UTC) #51
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/241609)
4 years, 5 months ago (2016-07-08 01:07:36 UTC) #53
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2120523002/240001
4 years, 5 months ago (2016-07-08 20:13:11 UTC) #60
commit-bot: I haz the power
Committed patchset #13 (id:240001)
4 years, 5 months ago (2016-07-08 20:18:02 UTC) #61
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-08 20:18:05 UTC) #62
commit-bot: I haz the power
4 years, 5 months ago (2016-07-08 20:19:18 UTC) #64
Message was sent while issue was closed.
Patchset 13 (id:??) landed as
https://crrev.com/734e21b735b81cc5c8ac04a98e330a9e7f51decd
Cr-Commit-Position: refs/heads/master@{#404478}

Powered by Google App Engine
This is Rietveld 408576698