third_party/WebKit/Source/modules/accessibility/AXNodeObject.h - Issue 2120523002: The children of non-editable combo boxes, search boxes and text fields should not be hidden

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/accessibility/AXNodeObject.h

Issue 2120523002: The children of non-editable combo boxes, search boxes and text fields should not be hidden (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixed Windows browser test. Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/modules/accessibility/AXNodeObject.h

diff --git a/third_party/WebKit/Source/modules/accessibility/AXNodeObject.h b/third_party/WebKit/Source/modules/accessibility/AXNodeObject.h

index c46b62018e8f6e787b0f91d3034d514a6ac718d4..14e98fd5f58e176f3021ad1f8b7c31cceec5d359 100644

--- a/third_party/WebKit/Source/modules/accessibility/AXNodeObject.h

+++ b/third_party/WebKit/Source/modules/accessibility/AXNodeObject.h

@@ -97,7 +97,7 @@ protected:

bool isAnchor() const final;

bool isControl() const override;

bool isControllingVideoElement() const;

- bool isEditable() const override { return isTextControl(); }

+ bool isEditable() const override { return isNativeTextControl(); }

bool isEmbeddedObject() const final;

bool isFieldset() const final;

bool isHeading() const final;

« no previous file with comments | « content/test/data/accessibility/html/input-datetime-expected-win.txt ('k') | no next file » | no next file with comments »