Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2120443002:
[system-health] Re-enable all passing smoke tests on the CQ (Closed)
|
Created:
4 years, 5 months ago by petrcermak Modified:
4 years, 5 months ago Reviewers:
nednguyen CC:
chromium-reviews, telemetry-reviews_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
Description[system-health] Re-enable all passing smoke tests on the CQ
All tests except for the following 3 passed in the most recent CQ dry
runs:
* load:tools:dropbox (crbug.com/624474)
* load:media:dailymotion (crbug.com/624607)
* load:games:bubbles (crbug.com/624701)
*** NOTE TO SHERRIF ***
If any of the
benchmarks.system_health_smoke_test.SystemHealthBenchmarkSmokeTest.*
tests fails, please do not revert this CL but instead disable only the
failing tests by adding them to the _DISABLE_TESTS list in
tools/perf/benchmarks/system_health_smoke_test.py. Thanks!
BUG=624474, 624587, 624607, 624701, 624840, 615382, 589726
TBR=nednguyen@google.com
CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:android_s5_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq
Committed: https://crrev.com/055373dbdafcd9bfceb0264df2554005cb22f536
Cr-Commit-Position: refs/heads/master@{#403470}
Patch Set 1 #Patch Set 2 : [system-health] Re-enable all smoke tests except for Dropbox #Patch Set 3 : Don't re-enable Dailymotion and Bubbles #Messages
Total messages: 20 (12 generated)
Description was changed from ========== [NOT FOR LANDING] Check which System Health smoke tests are still failing BUG=589726 ========== to ========== [NOT FOR LANDING] Check which System Health smoke tests are still failing BUG=589726 CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:android_s5_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq ==========
The CQ bit was checked by petrcermak@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
Description was changed from ========== [NOT FOR LANDING] Check which System Health smoke tests are still failing BUG=589726 CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:android_s5_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq ========== to ========== [system-health] Re-enable all smoke tests except for Dropbox on the CQ All tests except for load:tools:dropbox passed in the most recent CQ dry run. *** NOTE TO SHERRIF *** If any of the benchmarks.system_health_smoke_test.SystemHealthBenchmarkSmokeTest.* tests fails, please do not revert this CL but instead disable only the failing tests by adding them to the _DISABLE_TESTS list in tools/perf/benchmarks/system_health_smoke_test.py. Thanks! BUG=624474,624587,624607,624701,624840,615382,589726 CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:android_s5_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq ==========
Description was changed from ========== [system-health] Re-enable all smoke tests except for Dropbox on the CQ All tests except for load:tools:dropbox passed in the most recent CQ dry run. *** NOTE TO SHERRIF *** If any of the benchmarks.system_health_smoke_test.SystemHealthBenchmarkSmokeTest.* tests fails, please do not revert this CL but instead disable only the failing tests by adding them to the _DISABLE_TESTS list in tools/perf/benchmarks/system_health_smoke_test.py. Thanks! BUG=624474,624587,624607,624701,624840,615382,589726 CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:android_s5_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq ========== to ========== [system-health] Re-enable all smoke tests except for Dropbox on the CQ All tests except for load:tools:dropbox passed in the most recent CQ dry run. *** NOTE TO SHERRIF *** If any of the benchmarks.system_health_smoke_test.SystemHealthBenchmarkSmokeTest.* tests fails, please do not revert this CL but instead disable only the failing tests by adding them to the _DISABLE_TESTS list in tools/perf/benchmarks/system_health_smoke_test.py. Thanks! BUG=624474,624587,624607,624701,624840,615382,589726 TBR=nednguyen@google.com CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:android_s5_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq ==========
petrcermak@chromium.org changed reviewers: + nednguyen@google.com
PTAL. Thanks, Petr
The CQ bit was checked by petrcermak@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)
Description was changed from ========== [system-health] Re-enable all smoke tests except for Dropbox on the CQ All tests except for load:tools:dropbox passed in the most recent CQ dry run. *** NOTE TO SHERRIF *** If any of the benchmarks.system_health_smoke_test.SystemHealthBenchmarkSmokeTest.* tests fails, please do not revert this CL but instead disable only the failing tests by adding them to the _DISABLE_TESTS list in tools/perf/benchmarks/system_health_smoke_test.py. Thanks! BUG=624474,624587,624607,624701,624840,615382,589726 TBR=nednguyen@google.com CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:android_s5_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq ========== to ========== [system-health] Re-enable all passing smoke tests on the CQ All tests except for the following 3 passed in the most recent CQ dry runs: * load:tools:dropbox (crbug.com/624474) * load:media:dailymotion (crbug.com/624607) * load:games:bubbles (crbug.com/624701) *** NOTE TO SHERRIF *** If any of the benchmarks.system_health_smoke_test.SystemHealthBenchmarkSmokeTest.* tests fails, please do not revert this CL but instead disable only the failing tests by adding them to the _DISABLE_TESTS list in tools/perf/benchmarks/system_health_smoke_test.py. Thanks! BUG=624474,624587,624607,624701,624840,615382,589726 TBR=nednguyen@google.com CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:android_s5_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq ==========
The CQ bit was checked by petrcermak@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== [system-health] Re-enable all passing smoke tests on the CQ All tests except for the following 3 passed in the most recent CQ dry runs: * load:tools:dropbox (crbug.com/624474) * load:media:dailymotion (crbug.com/624607) * load:games:bubbles (crbug.com/624701) *** NOTE TO SHERRIF *** If any of the benchmarks.system_health_smoke_test.SystemHealthBenchmarkSmokeTest.* tests fails, please do not revert this CL but instead disable only the failing tests by adding them to the _DISABLE_TESTS list in tools/perf/benchmarks/system_health_smoke_test.py. Thanks! BUG=624474,624587,624607,624701,624840,615382,589726 TBR=nednguyen@google.com CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:android_s5_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq ========== to ========== [system-health] Re-enable all passing smoke tests on the CQ All tests except for the following 3 passed in the most recent CQ dry runs: * load:tools:dropbox (crbug.com/624474) * load:media:dailymotion (crbug.com/624607) * load:games:bubbles (crbug.com/624701) *** NOTE TO SHERRIF *** If any of the benchmarks.system_health_smoke_test.SystemHealthBenchmarkSmokeTest.* tests fails, please do not revert this CL but instead disable only the failing tests by adding them to the _DISABLE_TESTS list in tools/perf/benchmarks/system_health_smoke_test.py. Thanks! BUG=624474,624587,624607,624701,624840,615382,589726 TBR=nednguyen@google.com CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:android_s5_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== [system-health] Re-enable all passing smoke tests on the CQ All tests except for the following 3 passed in the most recent CQ dry runs: * load:tools:dropbox (crbug.com/624474) * load:media:dailymotion (crbug.com/624607) * load:games:bubbles (crbug.com/624701) *** NOTE TO SHERRIF *** If any of the benchmarks.system_health_smoke_test.SystemHealthBenchmarkSmokeTest.* tests fails, please do not revert this CL but instead disable only the failing tests by adding them to the _DISABLE_TESTS list in tools/perf/benchmarks/system_health_smoke_test.py. Thanks! BUG=624474,624587,624607,624701,624840,615382,589726 TBR=nednguyen@google.com CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:android_s5_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq ========== to ========== [system-health] Re-enable all passing smoke tests on the CQ All tests except for the following 3 passed in the most recent CQ dry runs: * load:tools:dropbox (crbug.com/624474) * load:media:dailymotion (crbug.com/624607) * load:games:bubbles (crbug.com/624701) *** NOTE TO SHERRIF *** If any of the benchmarks.system_health_smoke_test.SystemHealthBenchmarkSmokeTest.* tests fails, please do not revert this CL but instead disable only the failing tests by adding them to the _DISABLE_TESTS list in tools/perf/benchmarks/system_health_smoke_test.py. Thanks! BUG=624474,624587,624607,624701,624840,615382,589726 TBR=nednguyen@google.com CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:android_s5_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq Committed: https://crrev.com/055373dbdafcd9bfceb0264df2554005cb22f536 Cr-Commit-Position: refs/heads/master@{#403470} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/055373dbdafcd9bfceb0264df2554005cb22f536 Cr-Commit-Position: refs/heads/master@{#403470} |
