Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(819)

Side by Side Diff: tools/perf/benchmarks/system_health_smoke_test.py

Issue 2120443002: [system-health] Re-enable all passing smoke tests on the CQ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Don't re-enable Dailymotion and Bubbles Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2016 The Chromium Authors. All rights reserved. 1 # Copyright 2016 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 """Run all system health stories used by system health benchmarks. 5 """Run all system health stories used by system health benchmarks.
6 6
7 Only memory benchmarks are used when running these stories to make the total 7 Only memory benchmarks are used when running these stories to make the total
8 cycle time manageable. Other system health benchmarks should be using the same 8 cycle time manageable. Other system health benchmarks should be using the same
9 stories as memory ones, only with fewer actions (no memory dumping). 9 stories as memory ones, only with fewer actions (no memory dumping).
10 """ 10 """
(...skipping 20 matching lines...) Expand all
31 31
32 32
33 def GetSystemHealthBenchmarksToSmokeTest(): 33 def GetSystemHealthBenchmarksToSmokeTest():
34 sh_benchmark_classes = discover.DiscoverClassesInModule( 34 sh_benchmark_classes = discover.DiscoverClassesInModule(
35 system_health, perf_benchmark.PerfBenchmark, 35 system_health, perf_benchmark.PerfBenchmark,
36 index_by_class_name=True).values() 36 index_by_class_name=True).values()
37 return list(b for b in sh_benchmark_classes if 37 return list(b for b in sh_benchmark_classes if
38 b.Name().startswith('system_health.memory')) 38 b.Name().startswith('system_health.memory'))
39 39
40 40
41 _DISABLED_TESTS = [ 41 _DISABLED_TESTS = frozenset({
42 # crbug.com/624474 42 # crbug.com/624474
43 'benchmarks.system_health_smoke_test.SystemHealthBenchmarkSmokeTest.system_hea lth.memory_desktop.load:tools:dropbox', # pylint: disable=line-too-long 43 'benchmarks.system_health_smoke_test.SystemHealthBenchmarkSmokeTest.system_hea lth.memory_desktop.load:tools:dropbox', # pylint: disable=line-too-long
44 'benchmarks.system_health_smoke_test.SystemHealthBenchmarkSmokeTest.system_hea lth.memory_desktop.load:tools:docs', # pylint: disable=line-too-long
45 # crbug.com/624587
46 'benchmarks.system_health_smoke_test.SystemHealthBenchmarkSmokeTest.system_hea lth.memory_desktop.load:search:ebay', # pylint: disable=line-too-long
47 'benchmarks.system_health_smoke_test.SystemHealthBenchmarkSmokeTest.system_hea lth.memory_desktop.load:news:cnn', # pylint: disable=line-too-long
48 # crbug.com/624607 44 # crbug.com/624607
49 'benchmarks.system_health_smoke_test.SystemHealthBenchmarkSmokeTest.system_hea lth.memory_desktop.load:media:dailymotion', # pylint: disable=line-too-long 45 'benchmarks.system_health_smoke_test.SystemHealthBenchmarkSmokeTest.system_hea lth.memory_desktop.load:media:dailymotion', # pylint: disable=line-too-long
50 # crbug.com/624701 46 # crbug.com/624701
51 'benchmarks.system_health_smoke_test.SystemHealthBenchmarkSmokeTest.system_hea lth.memory_mobile.load:games:bubbles', # pylint: disable=line-too-long 47 'benchmarks.system_health_smoke_test.SystemHealthBenchmarkSmokeTest.system_hea lth.memory_mobile.load:games:bubbles', # pylint: disable=line-too-long
52 'benchmarks.system_health_smoke_test.SystemHealthBenchmarkSmokeTest.system_hea lth.memory_mobile.load:games:spychase', # pylint: disable=line-too-long 48 })
53 'benchmarks.system_health_smoke_test.SystemHealthBenchmarkSmokeTest.system_hea lth.memory_mobile.load:news:cnn', # pylint: disable=line-too-long
54 # crbug.com/624840
55 'benchmarks.system_health_smoke_test.SystemHealthBenchmarkSmokeTest.system_hea lth.memory_mobile.load:tools:drive', # pylint: disable=line-too-long
56 'benchmarks.system_health_smoke_test.SystemHealthBenchmarkSmokeTest.system_hea lth.memory_mobile.load:tools:dropbox', # pylint: disable=line-too-long
57 'benchmarks.system_health_smoke_test.SystemHealthBenchmarkSmokeTest.system_hea lth.memory_mobile.load:tools:gmail', # pylint: disable=line-too-long
58 ]
59 49
60 50
61 def _GenerateSmokeTestCase(benchmark_class, story_to_smoke_test): 51 def _GenerateSmokeTestCase(benchmark_class, story_to_smoke_test):
62 52
63 # NOTE TO SHERIFFS: DO NOT DISABLE THIS TEST. 53 # NOTE TO SHERIFFS: DO NOT DISABLE THIS TEST.
64 # 54 #
65 # This smoke test dynamically tests all system health user stories. So 55 # This smoke test dynamically tests all system health user stories. So
66 # disabling it for one failing or flaky benchmark would disable a much 56 # disabling it for one failing or flaky benchmark would disable a much
67 # wider swath of coverage than is usally intended. Instead, if a test is 57 # wider swath of coverage than is usally intended. Instead, if a test is
68 # failing, disable it by putting it into the _DISABLED_TESTS list above. 58 # failing, disable it by putting it into the _DISABLED_TESTS list above.
(...skipping 70 matching lines...) Expand 10 before | Expand all | Expand 10 after
139 # parsed during test time which happens after load_tests are called. 129 # parsed during test time which happens after load_tests are called.
140 # Since none of our system health benchmarks creates stories based on 130 # Since none of our system health benchmarks creates stories based on
141 # command line options, it should be ok to pass options=None to 131 # command line options, it should be ok to pass options=None to
142 # CreateStorySet. 132 # CreateStorySet.
143 for story_to_smoke_test in ( 133 for story_to_smoke_test in (
144 benchmark_class().CreateStorySet(options=None).stories): 134 benchmark_class().CreateStorySet(options=None).stories):
145 suite.addTest( 135 suite.addTest(
146 _GenerateSmokeTestCase(benchmark_class, story_to_smoke_test)) 136 _GenerateSmokeTestCase(benchmark_class, story_to_smoke_test))
147 137
148 return suite 138 return suite
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698