Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(897)

Issue 2120363002: Added WebRuntimeFeatures plumbing to enable Finch experiment. (Closed)

Created:
4 years, 5 months ago by mustaq
Modified:
4 years, 5 months ago
CC:
chromium-reviews, jam, dglazkov+blink, darin-cc_chromium.org, asvitkine+watch_chromium.org, blink-reviews, kinuko+watch, blink-reviews-api_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Added WebRuntimeFeatures plumbing to enable Finch experiment. BUG=624546 TBR=pfeldman@chromium.org

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -3 lines) Patch
M chrome/app/generated_resources.grd View 1 chunk +1 line, -1 line 0 comments Download
M content/child/runtime_features.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/public/common/content_features.cc View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/WebRuntimeFeatures.cpp View 1 chunk +5 lines, -0 lines 0 comments Download
M third_party/WebKit/public/web/WebRuntimeFeatures.h View 1 chunk +1 line, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 18 (8 generated)
mustaq
ptal
4 years, 5 months ago (2016-07-04 21:05:33 UTC) #2
dtapuska
On 2016/07/04 21:05:33, mustaq wrote: > ptal lgtm
4 years, 5 months ago (2016-07-04 21:27:29 UTC) #3
Rick Byers
LGTM
4 years, 5 months ago (2016-07-05 14:22:06 UTC) #4
mustaq
pfeldman@chromium.org: Please review changes in content/.*
4 years, 5 months ago (2016-07-05 15:18:37 UTC) #6
mustaq
rkaplow@chromium.org: Please review changes in histograms.xml
4 years, 5 months ago (2016-07-05 15:22:03 UTC) #8
rkaplow
lgtm
4 years, 5 months ago (2016-07-05 15:28:10 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2120363002/1
4 years, 5 months ago (2016-07-05 15:35:33 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/98580)
4 years, 5 months ago (2016-07-05 16:19:20 UTC) #16
dtapuska
On 2016/07/05 16:19:20, commit-bot: I haz the power wrote: > Try jobs failed on following ...
4 years, 5 months ago (2016-07-05 17:13:23 UTC) #17
mustaq
4 years, 5 months ago (2016-07-07 14:40:23 UTC) #18
On 2016/07/05 17:13:23, dtapuska wrote:
> On 2016/07/05 16:19:20, commit-bot: I haz the power wrote:
> > Try jobs failed on following builders:
> >   linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
> >
>
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
> 
> I've fixed the test failure in https://codereview.chromium.org/2125733002.
This
> issue can be closed once that one lands. I've TBR'd the reviewers on that one
> since it is good to go.

Thanks Dave for landing the patch as crrev.com/2125733002 in my absence. I will
close this one.

Powered by Google App Engine
This is Rietveld 408576698