Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2125733002: Added WebRuntimeFeatures plumbing to enable Finch experiment. (Closed)

Created:
4 years, 5 months ago by dtapuska
Modified:
4 years, 5 months ago
CC:
chromium-reviews, jam, dglazkov+blink, darin-cc_chromium.org, asvitkine+watch_chromium.org, blink-reviews, kinuko+watch, blink-reviews-api_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Added WebRuntimeFeatures plumbing to enable Finch experiment. Reviewed under https://codereview.chromium.org/2120363002/ but since mustaq@ is OOO and I can't upload a patch to a change owned by another user I need to upload it as a separate patch. BUG=624546 TBR=pfeldman@chromium.org, mustaq@chromium.org, rbyers@chromium.org, rkaplow@chromium.org Committed: https://crrev.com/02d58a8a81bf37dd6d303d96cfdff1c14e8d2c89 Cr-Commit-Position: refs/heads/master@{#403810}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -3 lines) Patch
M chrome/app/generated_resources.grd View 1 chunk +1 line, -1 line 0 comments Download
M content/child/runtime_features.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/public/common/content_features.cc View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/WebRuntimeFeatures.cpp View 1 chunk +5 lines, -0 lines 0 comments Download
M third_party/WebKit/public/web/WebRuntimeFeatures.h View 1 chunk +1 line, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2125733002/1
4 years, 5 months ago (2016-07-05 17:12:52 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-05 18:50:08 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/02d58a8a81bf37dd6d303d96cfdff1c14e8d2c89 Cr-Commit-Position: refs/heads/master@{#403810}
4 years, 5 months ago (2016-07-05 18:52:08 UTC) #5
mustaq
4 years, 5 months ago (2016-07-07 14:38:57 UTC) #6
Message was sent while issue was closed. 
On 2016/07/05 18:52:08, commit-bot: I haz the power wrote:
> Patchset 1 (id:??) landed as
> https://crrev.com/02d58a8a81bf37dd6d303d96cfdff1c14e8d2c89
> Cr-Commit-Position: refs/heads/master@{#403810}

lgtm

Powered by Google App Engine
This is Rietveld 408576698