Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(552)

Issue 2120293002: gpu, cmaa: Don't blend isolated L shape because it's not a closed geometry. (Closed)

Created:
4 years, 5 months ago by dshwang
Modified:
4 years, 5 months ago
CC:
chromium-reviews, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

gpu, cmaa: Don't blend isolated L shape because it's not a closed geometry. Isolated L shape means neighbor pixels doesn't have any edges continuing current two edge, as follows; _ _ X| X| |X |X ¯¯ ¯¯ We don't want to blur an open geometry. This CL fixes 2 WebGL conformance tests https://www.khronos.org/registry/webgl/sdk/tests/conformance/context/context-size-change.html https://www.khronos.org/registry/webgl/sdk/tests/conformance/textures/misc/copy-tex-image-and-sub-image-2d.html Yang Gu checked all WebGL conformance tests are passed with CMAA. BUG=535198 TEST=Run a WebGL app with Chrome started with "--enable-cmaa-shaders" CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel Committed: https://crrev.com/9df37c48526a8f6b350687e34e75b2eca1961736 Cr-Commit-Position: refs/heads/master@{#403821}

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -0 lines) Patch
M gpu/command_buffer/service/gles2_cmd_apply_framebuffer_attachment_cmaa_intel.cc View 1 chunk +28 lines, -0 lines 3 comments Download

Messages

Total messages: 22 (11 generated)
dshwang
jon, adrian, could you review? zmo@, could you review as owner? It's one of two ...
4 years, 5 months ago (2016-07-04 14:29:22 UTC) #4
adrian.belgun
lgtm
4 years, 5 months ago (2016-07-04 14:31:16 UTC) #5
Zhenyao Mo
https://codereview.chromium.org/2120293002/diff/1/gpu/command_buffer/service/gles2_cmd_apply_framebuffer_attachment_cmaa_intel.cc File gpu/command_buffer/service/gles2_cmd_apply_framebuffer_attachment_cmaa_intel.cc (right): https://codereview.chromium.org/2120293002/diff/1/gpu/command_buffer/service/gles2_cmd_apply_framebuffer_attachment_cmaa_intel.cc#newcode1576 gpu/command_buffer/service/gles2_cmd_apply_framebuffer_attachment_cmaa_intel.cc:1576: bool((packedEdgesL & 0x02u) == 0x00u) && I didn't review ...
4 years, 5 months ago (2016-07-05 01:47:27 UTC) #6
Zhenyao Mo
lgtm https://codereview.chromium.org/2120293002/diff/1/gpu/command_buffer/service/gles2_cmd_apply_framebuffer_attachment_cmaa_intel.cc File gpu/command_buffer/service/gles2_cmd_apply_framebuffer_attachment_cmaa_intel.cc (right): https://codereview.chromium.org/2120293002/diff/1/gpu/command_buffer/service/gles2_cmd_apply_framebuffer_attachment_cmaa_intel.cc#newcode1576 gpu/command_buffer/service/gles2_cmd_apply_framebuffer_attachment_cmaa_intel.cc:1576: bool((packedEdgesL & 0x02u) == 0x00u) && On 2016/07/05 ...
4 years, 5 months ago (2016-07-05 01:50:39 UTC) #7
jon.kennedy
On 2016/07/05 01:50:39, Zhenyao Mo wrote: > lgtm > > https://codereview.chromium.org/2120293002/diff/1/gpu/command_buffer/service/gles2_cmd_apply_framebuffer_attachment_cmaa_intel.cc > File > gpu/command_buffer/service/gles2_cmd_apply_framebuffer_attachment_cmaa_intel.cc ...
4 years, 5 months ago (2016-07-05 11:33:02 UTC) #8
dshwang
After rethinking, I want to change the logic. The shader handles 2 edge case like ...
4 years, 5 months ago (2016-07-05 11:41:26 UTC) #9
dshwang
On 2016/07/05 11:41:26, dshwang wrote: > After rethinking, I want to change the logic. > ...
4 years, 5 months ago (2016-07-05 12:44:48 UTC) #11
dshwang
On 2016/07/05 12:44:48, dshwang wrote: > On 2016/07/05 11:41:26, dshwang wrote: > > After rethinking, ...
4 years, 5 months ago (2016-07-05 18:51:23 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2120293002/1
4 years, 5 months ago (2016-07-05 18:51:53 UTC) #18
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-05 20:04:32 UTC) #20
commit-bot: I haz the power
4 years, 5 months ago (2016-07-05 20:05:58 UTC) #22
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9df37c48526a8f6b350687e34e75b2eca1961736
Cr-Commit-Position: refs/heads/master@{#403821}

Powered by Google App Engine
This is Rietveld 408576698