Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Issue 2120283002: Improve handling of DEPS OWNERS PRESUBMIT check (Closed)

Created:
4 years, 5 months ago by Paweł Hajdan Jr.
Modified:
4 years, 5 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Improve handling of DEPS OWNERS PRESUBMIT check BUG=593533 Committed: https://chromium.googlesource.com/chromium/src/+/ec17f88453662349b4ab73a51cf74bd416eca2da

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -7 lines) Patch
M PRESUBMIT.py View 1 chunk +7 lines, -7 lines 2 comments Download

Messages

Total messages: 9 (4 generated)
Bill Hesse
lgtm https://codereview.chromium.org/2120283002/diff/1/PRESUBMIT.py File PRESUBMIT.py (right): https://codereview.chromium.org/2120283002/diff/1/PRESUBMIT.py#newcode1106 PRESUBMIT.py:1106: '\n '.join(suggested_owners or []))) I wouldn't change the ...
4 years, 5 months ago (2016-07-04 14:13:17 UTC) #2
Paweł Hajdan Jr.
4 years, 5 months ago (2016-07-04 14:13:35 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/ec17f88453662349b4ab73a51cf74bd416eca2da Cr-Commit-Position: refs/heads/master@{#403680}
4 years, 5 months ago (2016-07-04 14:20:28 UTC) #6
Paweł Hajdan Jr.
Committed patchset #1 (id:1) manually as ec17f88453662349b4ab73a51cf74bd416eca2da (presubmit successful).
4 years, 5 months ago (2016-07-04 14:21:26 UTC) #8
tandrii(chromium)
4 years, 5 months ago (2016-07-04 17:21:39 UTC) #9
Message was sent while issue was closed.
lgtm

https://codereview.chromium.org/2120283002/diff/1/PRESUBMIT.py
File PRESUBMIT.py (right):

https://codereview.chromium.org/2120283002/diff/1/PRESUBMIT.py#newcode1106
PRESUBMIT.py:1106: '\n    '.join(suggested_owners or [])))
On 2016/07/04 14:13:16, Bill Hesse wrote:
> I wouldn't change the indents after % unless it is really done that way in all
> of the other code in this project.

indents in depot_tools are grossly inconsistent :(

Powered by Google App Engine
This is Rietveld 408576698