Chromium Code Reviews| Index: PRESUBMIT.py |
| diff --git a/PRESUBMIT.py b/PRESUBMIT.py |
| index 134f62dea44f8d3f034aff7d6d7d4cae9e9e3f94..1a3c40cad2c6ce5a6da975439b09b8593e3f1ae6 100644 |
| --- a/PRESUBMIT.py |
| +++ b/PRESUBMIT.py |
| @@ -1097,13 +1097,13 @@ def _CheckAddedDepsHaveTargetApprovals(input_api, output_api): |
| if unapproved_dependencies: |
| output_list = [ |
| - output('Missing LGTM from OWNERS of dependencies added to DEPS:\n %s' % |
| - '\n '.join(sorted(unapproved_dependencies)))] |
| - if not input_api.is_committing: |
| - suggested_owners = owners_db.reviewers_for(missing_files, owner_email) |
| - output_list.append(output( |
| - 'Suggested missing target path OWNERS:\n %s' % |
| - '\n '.join(suggested_owners or []))) |
| + output('You need LGTM from owners of depends-on paths in DEPS that were ' |
| + 'modified in this CL:\n %s' % |
| + '\n '.join(sorted(unapproved_dependencies)))] |
| + suggested_owners = owners_db.reviewers_for(missing_files, owner_email) |
| + output_list.append(output( |
| + 'Suggested missing target path OWNERS:\n %s' % |
| + '\n '.join(suggested_owners or []))) |
|
Bill Hesse
2016/07/04 14:13:16
I wouldn't change the indents after % unless it is
tandrii(chromium)
2016/07/04 17:21:39
indents in depot_tools are grossly inconsistent :(
|
| return output_list |
| return [] |