Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1343)

Unified Diff: content/renderer/media/audio_renderer_sink_cache_impl.h

Issue 2120273004: Getting rid of AudioHardwareConfig and its synchronous IPC. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: frame id fix Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/media/audio_renderer_sink_cache_impl.h
diff --git a/content/renderer/media/audio_renderer_sink_cache_impl.h b/content/renderer/media/audio_renderer_sink_cache_impl.h
index 7d163d9074c606acae482c5f181f2ecc732cf7ce..f0f5867c1ade50509c84690d9261ba1f7521d4ff 100644
--- a/content/renderer/media/audio_renderer_sink_cache_impl.h
+++ b/content/renderer/media/audio_renderer_sink_cache_impl.h
@@ -9,6 +9,7 @@
#include <vector>
+#include "base/optional.h"
#include "base/single_thread_task_runner.h"
#include "base/synchronization/lock.h"
#include "base/time/time.h"
@@ -91,6 +92,12 @@ class CONTENT_EXPORT AudioRendererSinkCacheImpl
base::Lock cache_lock_;
CacheContainer cache_;
+ // Cached default output device information. Since access to the default
+ // device is always allowed, this information can be cashed and shared among
DaleCurtis 2016/07/06 18:53:37 cached.
o1ka 2016/07/13 09:52:41 n/a any more
+ // all the clients. It is updated on the first request if not initialized yet,
+ // and each time a new default device sink is created in the cache.
+ base::Optional<media::OutputDeviceInfo> default_device_info_;
+
// Weak pointer to be used for delayed sink deletion on |task_runner_|.
// Pre-created in constructor and is used to post all the delayed tasks.
// A delayed task can be concurrently posted from any thread the cache is used

Powered by Google App Engine
This is Rietveld 408576698