Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2493)

Unified Diff: content/renderer/media/audio_device_factory.h

Issue 2120273004: Getting rid of AudioHardwareConfig and its synchronous IPC. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: frame id fix Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/media/audio_device_factory.h
diff --git a/content/renderer/media/audio_device_factory.h b/content/renderer/media/audio_device_factory.h
index 66936892b0bbbb90d0556b0d615e5c492eaea2a1..0ba01d0354609b59e1e24b949573ef4d29972223 100644
--- a/content/renderer/media/audio_device_factory.h
+++ b/content/renderer/media/audio_device_factory.h
@@ -48,6 +48,9 @@ class CONTENT_EXPORT AudioDeviceFactory {
kSourceLast = kSourceWebAudioExact // Only used for validation of format.
};
+ // TODO(olka, guidou): replace with actulal frame id everywhere.
Guido Urdaneta 2016/07/06 14:16:16 fix typo: s/actulal/actual
+ enum { kUnknownFrameIdForDefaultDevice = 1 };
DaleCurtis 2016/07/06 18:53:36 Why do we need this? Should we instead just have a
miu 2016/07/06 19:10:57 Not sure if I understand everything going on here,
o1ka 2016/07/13 09:52:41 removed
+
// Creates a sink for AudioRendererMixer.
// |render_frame_id| refers to the RenderFrame containing the entity
// producing the audio. If |session_id| is nonzero, it is used by the browser
@@ -85,6 +88,7 @@ class CONTENT_EXPORT AudioDeviceFactory {
const url::Origin& security_origin);
// A helper to get device info in the absence of AudioOutputDevice.
+ // Must be called on renderer thread only.
static media::OutputDeviceInfo GetOutputDeviceInfo(
int render_frame_id,
int session_id,

Powered by Google App Engine
This is Rietveld 408576698