Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1214)

Unified Diff: content/browser/renderer_host/render_message_filter.cc

Issue 2120273004: Getting rid of AudioHardwareConfig and its synchronous IPC. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: frame id fix Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/render_message_filter.cc
diff --git a/content/browser/renderer_host/render_message_filter.cc b/content/browser/renderer_host/render_message_filter.cc
index 3843d8865b2e74b3845da50cc6a5146b35ed208a..1eaf443da8bee238ddf88ace3870e648ae445ed4 100644
--- a/content/browser/renderer_host/render_message_filter.cc
+++ b/content/browser/renderer_host/render_message_filter.cc
@@ -212,8 +212,6 @@ bool RenderMessageFilter::OnMessageReceived(const IPC::Message& message) {
IPC_MESSAGE_HANDLER(
RenderProcessHostMsg_DidGenerateCacheableMetadataInCacheStorage,
OnCacheableMetadataAvailableForCacheStorage)
- IPC_MESSAGE_HANDLER(ViewHostMsg_GetAudioHardwareConfig,
- OnGetAudioHardwareConfig)
#if defined(OS_MACOSX)
IPC_MESSAGE_HANDLER_DELAY_REPLY(RenderProcessHostMsg_LoadFont, OnLoadFont)
#elif defined(OS_WIN)
@@ -240,9 +238,6 @@ void RenderMessageFilter::OverrideThreadForMessage(const IPC::Message& message,
base::TaskRunner* RenderMessageFilter::OverrideTaskRunnerForMessage(
const IPC::Message& message) {
- // Always query audio device parameters on the audio thread.
- if (message.type() == ViewHostMsg_GetAudioHardwareConfig::ID)
- return audio_manager_->GetTaskRunner();
return NULL;
DaleCurtis 2016/07/06 18:53:36 Remove this since no need anymore.
o1ka 2016/07/13 09:52:41 Done.
}
@@ -304,18 +299,6 @@ void RenderMessageFilter::OnGenerateRoutingID(int* route_id) {
*route_id = render_widget_helper_->GetNextRoutingID();
}
-void RenderMessageFilter::OnGetAudioHardwareConfig(
- media::AudioParameters* input_params,
- media::AudioParameters* output_params) {
- DCHECK(input_params);
- DCHECK(output_params);
- *output_params = audio_manager_->GetDefaultOutputStreamParameters();
-
- // TODO(henrika): add support for all available input devices.
- *input_params = audio_manager_->GetInputStreamParameters(
- media::AudioDeviceDescription::kDefaultDeviceId);
-}
-
#if defined(OS_MACOSX)
void RenderMessageFilter::OnLoadFont(const FontDescriptor& font,

Powered by Google App Engine
This is Rietveld 408576698