Port WebSockets to Mojo IPC

content/browser/bad_message.h

Index: content/browser/bad_message.h
diff --git a/content/browser/bad_message.h b/content/browser/bad_message.h
index c35dfa12ccd6c8857828a1f592b4159a9f4a1ee8..35d8279a883044d1c93457ef39b189907fd92237 100644
--- a/content/browser/bad_message.h
+++ b/content/browser/bad_message.h
@@ -132,8 +132,8 @@ enum BadMessageReason {
   RDHI_WRONG_STORAGE_PARTITION = 107,
   RDH_INVALID_REQUEST_ID = 108,
   BDH_SERVICE_NOT_ALLOWED_FOR_ORIGIN = 109,
-  WSH_SEND_BLOB_DURING_BLOB_SEND = 110,
-  WSH_SEND_FRAME_DURING_BLOB_SEND = 111,
+  WSI_UNEXPECTED_ADD_CHANNEL_REQUEST = 110,
+  WSI_UNEXPECTED_SEND_FRAME = 111,

[Ilya Sherman, 2016/08/18 01:11:18]

Hi, just wanted to check: Are the changes in this file semantically meaningful,
or simply clearer labels for identical events?  If they are semantically
meaningful, then these constants should not have been modified; instead, these
values should have been deprecated, and new values should have been added to the
tail end of the enum (since it backs an UMA histogram).

[Alexei Svitkine (slow), 2016/10/04 20:42:07]

Agree with Ilya on this general advise. However, I just checked the data and it
seems like the old values were never logged in practice - I don't see data for
them at all for last year. So I guess in this instance we can live with the
change without needing to retroactively try to renumber the new values.

But just a heads up for reviewers to watch out for cases where an enum that's
logged in UMA is being renumbered or re-used - as this will confuse the data
since a given value may mean different things depending on Chrome version.

   RFH_UNEXPECTED_LOAD_START = 112,
   NMF_INVALID_ARGUMENT = 113,
   RFH_INVALID_ORIGIN_ON_COMMIT = 114,
@@ -149,7 +149,7 @@ enum BadMessageReason {
   DBMF_INVALID_ORIGIN_ON_GET_SPACE = 124,
   DBMF_INVALID_ORIGIN_ON_MODIFIED = 125,
   DBMF_INVALID_ORIGIN_ON_CLOSED = 126,
-  WSH_INVALID_HEADER_VALUE = 127,
+  WSI_INVALID_HEADER_VALUE = 127,
   SWDH_SET_HOSTED_VERSION_INVALID_HOST = 128,
   SWDH_SET_HOSTED_VERSION_PROCESS_MISMATCH = 129,
   MSDH_INVALID_FRAME_ID = 130,
@@ -169,6 +169,9 @@ enum BadMessageReason {
 // and terminates the process for |host|.
 void ReceivedBadMessage(RenderProcessHost* host, BadMessageReason reason);
 
+// Equivalent to the above, but callable from any thread.
+void ReceivedBadMessage(int render_process_id, BadMessageReason reason);
+
 // Called when a browser message filter receives a bad IPC message from a
 // renderer or other child process. Logs the event, records a histogram metric
 // for the |reason|, and terminates the process for |filter|.