Port WebSockets to Mojo IPC

content/browser/bad_message.h

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_BROWSER_BAD_MESSAGE_H_
 #define CONTENT_BROWSER_BAD_MESSAGE_H_
 
 namespace content {
 class BrowserMessageFilter;
 class RenderProcessHost;
@@ skipping 114 matching lines @@
   // obsolete; no longer used
   WC_CONTENT_WITH_CERT_ERRORS_BAD_SECURITY_INFO = 101,
   RFMF_RENDERER_FAKED_ITS_OWN_DEATH = 102,
   DWNLD_INVALID_SAVABLE_RESOURCE_LINKS_RESPONSE = 103,
   DWNLD_INVALID_SERIALIZE_AS_MHTML_RESPONSE = 104,
   BDH_DEVICE_NOT_ALLOWED_FOR_ORIGIN = 105,
   ACI_WRONG_STORAGE_PARTITION = 106,
   RDHI_WRONG_STORAGE_PARTITION = 107,
   RDH_INVALID_REQUEST_ID = 108,
   BDH_SERVICE_NOT_ALLOWED_FOR_ORIGIN = 109,
-  WSH_SEND_BLOB_DURING_BLOB_SEND = 110,
-  WSH_SEND_FRAME_DURING_BLOB_SEND = 111,
+  WSI_UNEXPECTED_ADD_CHANNEL_REQUEST = 110,
+  WSI_UNEXPECTED_SEND_FRAME = 111,

[Ilya Sherman, 2016/08/18 01:11:18]

Hi, just wanted to check: Are the changes in this file semantically meaningful,
or simply clearer labels for identical events?  If they are semantically
meaningful, then these constants should not have been modified; instead, these
values should have been deprecated, and new values should have been added to the
tail end of the enum (since it backs an UMA histogram).

[Alexei Svitkine (slow), 2016/10/04 20:42:07]

Agree with Ilya on this general advise. However, I just checked the data and it
seems like the old values were never logged in practice - I don't see data for
them at all for last year. So I guess in this instance we can live with the
change without needing to retroactively try to renumber the new values.

But just a heads up for reviewers to watch out for cases where an enum that's
logged in UMA is being renumbered or re-used - as this will confuse the data
since a given value may mean different things depending on Chrome version.

   RFH_UNEXPECTED_LOAD_START = 112,
   NMF_INVALID_ARGUMENT = 113,
   RFH_INVALID_ORIGIN_ON_COMMIT = 114,
   BDH_UUID_REGISTERED = 115,
   BDH_CONSTRUCTION_FAILED = 116,
   BDH_INVALID_REFCOUNT_OPERATION = 117,
   BDH_INVALID_URL_OPERATION = 118,
   IDBDH_INVALID_ORIGIN = 119,
   RFH_FAIL_PROVISIONAL_LOAD_NO_HANDLE = 120,
   RFH_FAIL_PROVISIONAL_LOAD_NO_ERROR = 121,
   NI_IN_PAGE_NAVIGATION = 122,
   RPH_MOJO_PROCESS_ERROR = 123,
   DBMF_INVALID_ORIGIN_ON_GET_SPACE = 124,
   DBMF_INVALID_ORIGIN_ON_MODIFIED = 125,
   DBMF_INVALID_ORIGIN_ON_CLOSED = 126,
-  WSH_INVALID_HEADER_VALUE = 127,
+  WSI_INVALID_HEADER_VALUE = 127,
   SWDH_SET_HOSTED_VERSION_INVALID_HOST = 128,
   SWDH_SET_HOSTED_VERSION_PROCESS_MISMATCH = 129,
   MSDH_INVALID_FRAME_ID = 130,
   SDH_INVALID_PORT_RANGE = 131,
   SCO_INVALID_ARGUMENT = 132,
   RFH_INCONSISTENT_DEVTOOLS_MESSAGE = 133,
 
   // Please add new elements here. The naming convention is abbreviated class
   // name (e.g. RenderFrameHost becomes RFH) plus a unique description of the
   // reason. After making changes, you MUST update histograms.xml by running:
   // "python tools/metrics/histograms/update_bad_message_reasons.py"
   BAD_MESSAGE_MAX
 };
 
 // Called when the browser receives a bad IPC message from a renderer process on
 // the UI thread. Logs the event, records a histogram metric for the |reason|,
 // and terminates the process for |host|.
 void ReceivedBadMessage(RenderProcessHost* host, BadMessageReason reason);
 
+// Equivalent to the above, but callable from any thread.
+void ReceivedBadMessage(int render_process_id, BadMessageReason reason);
+
 // Called when a browser message filter receives a bad IPC message from a
 // renderer or other child process. Logs the event, records a histogram metric
 // for the |reason|, and terminates the process for |filter|.
 void ReceivedBadMessage(BrowserMessageFilter* filter, BadMessageReason reason);
 
 }  // namespace bad_message
 }  // namespace content
 
 #endif  // CONTENT_BROWSER_BAD_MESSAGE_H_