Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(545)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2119933003: Add Configurable metric_name_prefix (Closed)

Created:
4 years, 5 months ago by tnn
Modified:
4 years, 5 months ago
Reviewers:
Sergey Berezin
CC:
chromium-reviews, infra-reviews+infra_chromium.org
Base URL:
https://chromium.googlesource.com/infra/infra.git@master
Target Ref:
refs/heads/master
Project:
infra
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : Add trailing slash #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -1 line) Patch
M infra_libs/ts_mon/common/interface.py View 1 1 chunk +2 lines, -0 lines 0 comments Download
M infra_libs/ts_mon/common/metrics.py View 1 chunk +1 line, -1 line 0 comments Download
M infra_libs/ts_mon/config.py View 1 2 chunks +5 lines, -0 lines 0 comments Download
M infra_libs/ts_mon/test/config_test.py View 1 2 chunks +8 lines, -0 lines 0 comments Download

Messages

Total messages: 21 (8 generated)
tnn
4 years, 5 months ago (2016-07-01 23:12:33 UTC) #1
tnn
On 2016/07/01 23:12:33, tanin wrote: A friendly ping after a long weekend.
4 years, 5 months ago (2016-07-06 16:12:03 UTC) #2
Sergey Berezin
LGTM, thanks!
4 years, 5 months ago (2016-07-06 17:20:43 UTC) #3
tnn
On 2016/07/06 17:20:43, Sergey Berezin wrote: > LGTM, thanks! I'll `git cl land` this.
4 years, 5 months ago (2016-07-06 17:30:18 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2119933003/1
4 years, 5 months ago (2016-07-06 17:36:21 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: Infra Linux Trusty 64 Tester on master.tryserver.infra (JOB_FAILED, https://build.chromium.org/p/tryserver.infra/builders/Infra%20Linux%20Trusty%2064%20Tester/builds/2934) ...
4 years, 5 months ago (2016-07-06 17:44:12 UTC) #8
Sergey Berezin
https://codereview.chromium.org/2119933003/diff/1/infra_libs/ts_mon/common/interface.py File infra_libs/ts_mon/common/interface.py (right): https://codereview.chromium.org/2119933003/diff/1/infra_libs/ts_mon/common/interface.py#newcode81 infra_libs/ts_mon/common/interface.py:81: self.metric_name_prefix = '/chrome/infra' '/chrome/infra/' (trailing slash). This may or ...
4 years, 5 months ago (2016-07-06 17:49:12 UTC) #9
tnn
On 2016/07/06 17:49:12, Sergey Berezin wrote: > https://codereview.chromium.org/2119933003/diff/1/infra_libs/ts_mon/common/interface.py > File infra_libs/ts_mon/common/interface.py (right): > > https://codereview.chromium.org/2119933003/diff/1/infra_libs/ts_mon/common/interface.py#newcode81 ...
4 years, 5 months ago (2016-07-06 17:52:51 UTC) #10
tnn
4 years, 5 months ago (2016-07-06 17:55:45 UTC) #12
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2119933003/40001
4 years, 5 months ago (2016-07-06 17:56:45 UTC) #14
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 5 months ago (2016-07-06 18:12:58 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2119933003/40001
4 years, 5 months ago (2016-07-06 18:13:44 UTC) #19
commit-bot: I haz the power
4 years, 5 months ago (2016-07-06 18:15:19 UTC) #21
Message was sent while issue was closed. 
Committed patchset #2 (id:40001) as
https://chromium.googlesource.com/infra/infra/+/db2a299c44a6a970cfb31c45669b1...

Powered by Google App Engine
This is Rietveld 408576698