Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(404)

Issue 2119893002: Native text field elements shouldn't allow aria-owns children. (Closed)

Created:
4 years, 5 months ago by dmazzoni
Modified:
4 years, 5 months ago
Reviewers:
nektarios
CC:
nektarios, aboxhall+watch_chromium.org, aboxhall, blink-reviews, chromium-reviews, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, haraken, je_julie, nektar+watch_chromium.org, yuzo+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Native text field elements shouldn't allow aria-owns children. BUG=620432 Committed: https://crrev.com/6647bd1dd8ba1f3f32e8e636f834270e5ee0edf3 Cr-Commit-Position: refs/heads/master@{#403537}

Patch Set 1 #

Patch Set 2 : Update aria-activedescendant expectation #

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+65 lines, -1 line) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/accessibility/aria-owns-ignores-leafs.html View 1 chunk +62 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/accessibility/AXNodeObject.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (4 generated)
dmazzoni
4 years, 5 months ago (2016-07-01 17:45:52 UTC) #2
chromium-reviews
+ if (canHaveChildren() && !isNativeTextControl() && !hasContentEditableAttributeSet()) Isn't it better to use isRichlyEditable() instead of ...
4 years, 5 months ago (2016-07-01 18:24:42 UTC) #3
blink-reviews
+ if (canHaveChildren() && !isNativeTextControl() && !hasContentEditableAttributeSet()) Isn't it better to use isRichlyEditable() instead of ...
4 years, 5 months ago (2016-07-01 18:24:43 UTC) #4
dmazzoni
On 2016/07/01 18:24:43, blink-reviews wrote: > + if (canHaveChildren() && !isNativeTextControl() && > !hasContentEditableAttributeSet()) > ...
4 years, 5 months ago (2016-07-01 18:53:03 UTC) #5
nektarios
lgtm
4 years, 5 months ago (2016-07-01 18:55:20 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2119893002/40001
4 years, 5 months ago (2016-07-01 19:06:28 UTC) #9
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 5 months ago (2016-07-01 21:30:02 UTC) #10
commit-bot: I haz the power
4 years, 5 months ago (2016-07-01 21:31:47 UTC) #12
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/6647bd1dd8ba1f3f32e8e636f834270e5ee0edf3
Cr-Commit-Position: refs/heads/master@{#403537}

Powered by Google App Engine
This is Rietveld 408576698