Native text field elements shouldn't allow aria-owns children.

Native text field elements shouldn't allow aria-owns children.

BUG=620432
Committed: https://crrev.com/6647bd1dd8ba1f3f32e8e636f834270e5ee0edf3
Cr-Commit-Position: refs/heads/master@{#403537}

[dmazzoni, 2016-07-01 17:45:52]

dmazzoni@chromium.org changed reviewers:
+ nektar@chromium.org

[chromium-reviews, 2016-07-01 18:24:42]

+ if (canHaveChildren() && !isNativeTextControl() && 
!hasContentEditableAttributeSet())

Isn't it better to use isRichlyEditable() instead of 
hasContentAttributeSet().
Then, if a child of a content editable tries to use aria-owns it would 
also be disallowed.

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[blink-reviews, 2016-07-01 18:24:43]

+ if (canHaveChildren() && !isNativeTextControl() && 
!hasContentEditableAttributeSet())

Isn't it better to use isRichlyEditable() instead of 
hasContentAttributeSet().
Then, if a child of a content editable tries to use aria-owns it would 
also be disallowed.

-- 
You received this message because you are subscribed to the Google Groups "Blink
Reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to blink-reviews+unsubscribe@chromium.org.

[dmazzoni, 2016-07-01 18:53:03]

On 2016/07/01 18:24:43, blink-reviews wrote:
> + if (canHaveChildren() && !isNativeTextControl() && 
> !hasContentEditableAttributeSet())
> 
> Isn't it better to use isRichlyEditable() instead of 
> hasContentAttributeSet().
> Then, if a child of a content editable tries to use aria-owns it would 
> also be disallowed.

I'm not sure about that. What if the whole document is editable or it really is
rich text? Shouldn't it be possible to use aria-owns inside that?

I think the thing we want to avoid is using aria-owns to indicate a dropdown
list, when aria-controls really would have been better.

[nektarios, 2016-07-01 18:55:20]

lgtm

[dmazzoni, 2016-07-01 19:06:00]

The CQ bit was checked by dmazzoni@chromium.org

[dmazzoni, 2016-07-01 19:06:00]

The patchset sent to the CQ was uploaded after l-g-t-m from nektar@chromium.org
Link to the patchset: https://codereview.chromium.org/2119893002/#ps40001
(title: "Rebase")

[commit-bot: I haz the power, 2016-07-01 19:06:28]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-01 21:30:02]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-07-01 21:31:46]

Description was changed from

==========
Native text field elements shouldn't allow aria-owns children.

BUG=620432
==========

to

==========
Native text field elements shouldn't allow aria-owns children.

BUG=620432

Committed: https://crrev.com/6647bd1dd8ba1f3f32e8e636f834270e5ee0edf3
Cr-Commit-Position: refs/heads/master@{#403537}
==========

[commit-bot: I haz the power, 2016-07-01 21:31:47]

Patchset 3 (id:??) landed as
https://crrev.com/6647bd1dd8ba1f3f32e8e636f834270e5ee0edf3
Cr-Commit-Position: refs/heads/master@{#403537}