third_party/WebKit/Source/modules/accessibility/AXNodeObject.cpp - Issue 2119893002: Native text field elements shouldn't allow aria-owns children.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/accessibility/AXNodeObject.cpp

Issue 2119893002: Native text field elements shouldn't allow aria-owns children. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/modules/accessibility/AXNodeObject.cpp

diff --git a/third_party/WebKit/Source/modules/accessibility/AXNodeObject.cpp b/third_party/WebKit/Source/modules/accessibility/AXNodeObject.cpp

index ce6c8ae131c6d02696b0c93413799abb8f8562f5..176a48c22a4dae8e21ccf8f2e1964df99cea1061 100644

--- a/third_party/WebKit/Source/modules/accessibility/AXNodeObject.cpp

+++ b/third_party/WebKit/Source/modules/accessibility/AXNodeObject.cpp

@@ -2188,7 +2188,7 @@ void AXNodeObject::computeAriaOwnsChildren(HeapVector<Member<AXObject>>& ownedCh

return;

Vector<String> idVector;

- if (canHaveChildren())

+ if (canHaveChildren() && !isNativeTextControl() && !hasContentEditableAttributeSet())

tokenVectorFromAttribute(idVector, aria_ownsAttr);

axObjectCache().updateAriaOwns(this, idVector, ownedChildren);

« no previous file with comments | « third_party/WebKit/LayoutTests/accessibility/aria-owns-ignores-leafs.html ('k') | no next file » | no next file with comments »