Add logging for distinguishing between captive portals with HTTP and HTTPS login pages

chrome/browser/captive_portal/captive_portal_detector.h

Index: chrome/browser/captive_portal/captive_portal_detector.h
diff --git a/chrome/browser/captive_portal/captive_portal_detector.h b/chrome/browser/captive_portal/captive_portal_detector.h
index 162ae6e150b55197f70ab5477425518c8163d676..da8b1a9aff744ff4b9841aad22776f223272cd22 100644
--- a/chrome/browser/captive_portal/captive_portal_detector.h
+++ b/chrome/browser/captive_portal/captive_portal_detector.h
@@ -38,12 +38,14 @@ class CaptivePortalDetector : public net::URLFetcherDelegate,
   struct Results {
     Results()
         : result(RESULT_NO_RESPONSE),
-          response_code(net::URLFetcher::RESPONSE_CODE_INVALID) {
+          response_code(net::URLFetcher::RESPONSE_CODE_INVALID),
+          is_response_https(false) {
     }
 
     Result result;
     int response_code;
     base::TimeDelta retry_after_delta;
+    bool is_response_https;

[mmenke, 2014/03/26 14:46:08]

This should be was_redirected_to_https, since the initial response is always
HTTP.

However, I think it would make more sense to just record the final URL, and let
the consumer decide what to do with it - this is more flexible for future logic
(Could, for instance, open the new tab at this URL, rather than following the
redirects)

[meacer, 2014/03/26 17:04:57]

Done.

   };
 
   typedef base::Callback<void(const Results& results)> DetectionCallback;