chrome/browser/captive_portal/captive_portal_detector.cc - Issue 211983002: Add logging for distinguishing between captive portals with HTTP and HTTPS login pages

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/captive_portal/captive_portal_detector.cc

Issue 211983002: Add logging for distinguishing between captive portals with HTTP and HTTPS login pages (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/captive_portal/captive_portal_detector.h ('K') | « chrome/browser/captive_portal/captive_portal_detector.h ('k') | chrome/browser/captive_portal/captive_portal_service.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/captive_portal/captive_portal_detector.cc

diff --git a/chrome/browser/captive_portal/captive_portal_detector.cc b/chrome/browser/captive_portal/captive_portal_detector.cc

index 26f1a2020ab496d3e9d880b3244f25465577f691..1bb7dae469e348c60dc2273365724c78a802668f 100644

--- a/chrome/browser/captive_portal/captive_portal_detector.cc

+++ b/chrome/browser/captive_portal/captive_portal_detector.cc

@@ -103,6 +103,7 @@ void CaptivePortalDetector::GetCaptivePortalResultFromResponse(

results->result = RESULT_NO_RESPONSE;

results->response_code = url_fetcher->GetResponseCode();

results->retry_after_delta = base::TimeDelta();

+ results->is_response_https = url_fetcher->GetURL().SchemeIs("https");

// If there's a network error of some sort when fetching a file via HTTP,

// there may be a networking problem, rather than a captive portal.