Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2119813004:
Hide geometry class in AAStrokeRectBatch and remove unused Append function (Closed)
|
Created:
4 years, 5 months ago by bsalomon Modified:
4 years, 5 months ago Reviewers:
robertphillips CC:
reviews_skia.org Base URL:
https://skia.googlesource.com/skia.git@master Target Ref:
refs/heads/master Project:
skia Visibility:
Public. |
DescriptionHide geometry class in AAStrokeRectBatch and remove unused Append function.
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2119813004
Committed: https://skia.googlesource.com/skia/+/8b7a9e1e5a773cbc2ccf9ee1b36e8dce5ddfb8c5
Patch Set 1 #Patch Set 2 : finish #
Total comments: 2
Patch Set 3 : rebase #Patch Set 4 : fix #
Total comments: 2
Patch Set 5 : init view matrix for fill between two rects case #Messages
Total messages: 21 (10 generated)
Description was changed from ========== Hide geometry class in AAStrokeRectBatch ========== to ========== Hide geometry class in AAStrokeRectBatch GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2119813004 ==========
bsalomon@google.com changed reviewers: + robertphillips@google.com
https://codereview.chromium.org/2119813004/diff/20001/src/gpu/batches/GrAAStr... File src/gpu/batches/GrAAStrokeRectBatch.cpp (right): https://codereview.chromium.org/2119813004/diff/20001/src/gpu/batches/GrAAStr... src/gpu/batches/GrAAStrokeRectBatch.cpp:24: inline static bool is_miter(const SkStrokeRec& stroke) { These two functions are just moved from below.
Description was changed from ========== Hide geometry class in AAStrokeRectBatch GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2119813004 ========== to ========== Hide geometry class in AAStrokeRectBatch and remove unused Append function. GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2119813004 ==========
The CQ bit was checked by bsalomon@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: Build-Win-MSVC-x86-Debug-Trybot on master.client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Win-MSVC-x86-D...)
https://codereview.chromium.org/2119813004/diff/20001/src/gpu/batches/GrAAStr... File src/gpu/batches/GrAAStrokeRectBatch.cpp (left): https://codereview.chromium.org/2119813004/diff/20001/src/gpu/batches/GrAAStr... src/gpu/batches/GrAAStrokeRectBatch.cpp:113: : INHERITED(ClassID()) { Where did the init of 'fViewMatrix' go ? Can we remove it ?
On 2016/07/01 19:14:01, robertphillips wrote: > https://codereview.chromium.org/2119813004/diff/20001/src/gpu/batches/GrAAStr... > File src/gpu/batches/GrAAStrokeRectBatch.cpp (left): > > https://codereview.chromium.org/2119813004/diff/20001/src/gpu/batches/GrAAStr... > src/gpu/batches/GrAAStrokeRectBatch.cpp:113: : INHERITED(ClassID()) { > Where did the init of 'fViewMatrix' go ? > Can we remove it ? There was no test that required it. Now there is and I've rebaselined this CL on the CL that added the test and it now retains the view matrix in the batch.
lgtm https://codereview.chromium.org/2119813004/diff/60001/src/gpu/batches/GrAAStr... File src/gpu/batches/GrAAStrokeRectBatch.cpp (right): https://codereview.chromium.org/2119813004/diff/60001/src/gpu/batches/GrAAStr... src/gpu/batches/GrAAStrokeRectBatch.cpp:124: const SkRect& devOutside, const SkRect& devInside) : AAStrokeRectBatch() { , fViewMatrix(viewMatrix) ?
The CQ bit was checked by bsalomon@google.com
The patchset sent to the CQ was uploaded after l-g-t-m from robertphillips@google.com Link to the patchset: https://codereview.chromium.org/2119813004/#ps80001 (title: "init view matrix for fill between two rects case")
https://codereview.chromium.org/2119813004/diff/60001/src/gpu/batches/GrAAStr... File src/gpu/batches/GrAAStrokeRectBatch.cpp (right): https://codereview.chromium.org/2119813004/diff/60001/src/gpu/batches/GrAAStr... src/gpu/batches/GrAAStrokeRectBatch.cpp:124: const SkRect& devOutside, const SkRect& devInside) : AAStrokeRectBatch() { On 2016/07/06 18:42:37, robertphillips wrote: > , fViewMatrix(viewMatrix) ? Done.
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: Build-Win-MSVC-x86-Debug-Trybot on master.client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Win-MSVC-x86-D...)
The CQ bit was checked by bsalomon@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Hide geometry class in AAStrokeRectBatch and remove unused Append function. GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2119813004 ========== to ========== Hide geometry class in AAStrokeRectBatch and remove unused Append function. GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2119813004 Committed: https://skia.googlesource.com/skia/+/8b7a9e1e5a773cbc2ccf9ee1b36e8dce5ddfb8c5 ==========
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as https://skia.googlesource.com/skia/+/8b7a9e1e5a773cbc2ccf9ee1b36e8dce5ddfb8c5 |
