Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(492)

Issue 2126893002: Hide NonAAStrokeRectBatch Geometry class and cleanup class. (Closed)

Created:
4 years, 5 months ago by bsalomon
Modified:
4 years, 5 months ago
Reviewers:
robertphillips
CC:
reviews_skia.org
Base URL:
https://chromium.googlesource.com/skia.git@aastrokerectbatch
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Hide NonAAStrokeRectBatch Geometry class and cleanup class. GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2126893002 Committed: https://skia.googlesource.com/skia/+/28ef39624ad8d2e69fd44af9d9dfb26bd3aedd57

Patch Set 1 #

Patch Set 2 : fix indent #

Patch Set 3 : whitespace fix #

Total comments: 1

Patch Set 4 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -120 lines) Patch
M src/gpu/batches/GrAAStrokeRectBatch.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M src/gpu/batches/GrNonAAStrokeRectBatch.cpp View 1 2 3 4 chunks +59 lines, -119 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
bsalomon
4 years, 5 months ago (2016-07-06 19:46:18 UTC) #3
robertphillips
lgtm https://codereview.chromium.org/2126893002/diff/40001/src/gpu/batches/GrNonAAStrokeRectBatch.cpp File src/gpu/batches/GrNonAAStrokeRectBatch.cpp (right): https://codereview.chromium.org/2126893002/diff/40001/src/gpu/batches/GrNonAAStrokeRectBatch.cpp#newcode81 src/gpu/batches/GrNonAAStrokeRectBatch.cpp:81: if (snapToPixelCenters) { Greg just posted a CL ...
4 years, 5 months ago (2016-07-06 20:44:06 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2126893002/60001
4 years, 5 months ago (2016-07-07 01:41:10 UTC) #7
commit-bot: I haz the power
4 years, 5 months ago (2016-07-07 01:56:09 UTC) #9
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://skia.googlesource.com/skia/+/28ef39624ad8d2e69fd44af9d9dfb26bd3aedd57

Powered by Google App Engine
This is Rietveld 408576698