Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1063)

Issue 2119793002: X87: [ia32] Fixes a bug in cmpw. (Closed)

Created:
4 years, 5 months ago by zhengxing.li
Modified:
4 years, 5 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: [ia32] Fixes a bug in cmpw. port 588e15c0343ba3052b15887f08a84bcd03f7e233 (r37345) original commit message: The opcodes for 'cmpw r/m16, r16' and 'cmpw r16, r/m16' were swapped, causing a few issues when less than/greater than comparison were performed. Adds a regression test. BUG= Committed: https://crrev.com/d781b9561997fba1ae0315b020b79abf71959e7f Cr-Commit-Position: refs/heads/master@{#37469}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -6 lines) Patch
M src/x87/assembler-x87.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/x87/disasm-x87.cc View 2 chunks +17 lines, -4 lines 0 comments Download
M test/cctest/test-assembler-x87.cc View 1 chunk +41 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
zhengxing.li
PTAL, thanks!
4 years, 5 months ago (2016-07-01 02:50:14 UTC) #2
Weiliang
lgtm
4 years, 5 months ago (2016-07-01 03:30:03 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2119793002/1
4 years, 5 months ago (2016-07-01 04:29:49 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-01 05:01:06 UTC) #6
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-01 05:01:09 UTC) #7
commit-bot: I haz the power
4 years, 5 months ago (2016-07-01 05:01:46 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d781b9561997fba1ae0315b020b79abf71959e7f
Cr-Commit-Position: refs/heads/master@{#37469}

Powered by Google App Engine
This is Rietveld 408576698