Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(325)

Side by Side Diff: test/cctest/test-assembler-x87.cc

Issue 2119793002: X87: [ia32] Fixes a bug in cmpw. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/x87/disasm-x87.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2011 the V8 project authors. All rights reserved. 1 // Copyright 2011 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 389 matching lines...) Expand 10 before | Expand all | Expand 10 after
400 code->Print(os); 400 code->Print(os);
401 #endif 401 #endif
402 F1 f = FUNCTION_CAST<F1>(code->entry()); 402 F1 f = FUNCTION_CAST<F1>(code->entry());
403 for (int i = 0; i < kNumCases; ++i) { 403 for (int i = 0; i < kNumCases; ++i) {
404 int res = f(i); 404 int res = f(i);
405 ::printf("f(%d) = %d\n", i, res); 405 ::printf("f(%d) = %d\n", i, res);
406 CHECK_EQ(values[i], res); 406 CHECK_EQ(values[i], res);
407 } 407 }
408 } 408 }
409 409
410 TEST(Regress621926) {
411 // Bug description:
412 // The opcodes for cmpw r/m16, r16 and cmpw r16, r/m16 were swapped.
413 // This was causing non-commutative comparisons to produce the wrong result.
414 CcTest::InitializeVM();
415 Isolate* isolate = reinterpret_cast<Isolate*>(CcTest::isolate());
416 HandleScope scope(isolate);
417 Assembler assm(isolate, nullptr, 0);
418
419 int16_t a = 42;
420
421 Label fail;
422 __ push(ebx);
423 __ mov(ebx, Immediate(reinterpret_cast<intptr_t>(&a)));
424 __ mov(eax, Immediate(41));
425 __ cmpw(eax, Operand(ebx));
426 __ j(above_equal, &fail);
427 __ cmpw(Operand(ebx), eax);
428 __ j(below_equal, &fail);
429 __ mov(eax, 1);
430 __ pop(ebx);
431 __ ret(0);
432 __ bind(&fail);
433 __ mov(eax, 0);
434 __ pop(ebx);
435 __ ret(0);
436
437 CodeDesc desc;
438 assm.GetCode(&desc);
439 Handle<Code> code = isolate->factory()->NewCode(
440 desc, Code::ComputeFlags(Code::STUB), Handle<Code>());
441
442 #ifdef OBJECT_PRINT
443 OFStream os(stdout);
444 code->Print(os);
445 #endif
446
447 F0 f = FUNCTION_CAST<F0>(code->entry());
448 CHECK_EQ(f(), 1);
449 }
450
410 #undef __ 451 #undef __
OLDNEW
« no previous file with comments | « src/x87/disasm-x87.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698