src/parsing/scanner.cc - Issue 2119763003: Recognize HTMLCloseComment after multiline comment

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/parsing/scanner.cc

Issue 2119763003: Recognize HTMLCloseComment after multiline comment (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: add more test cases Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/parsing/scanner.cc

diff --git a/src/parsing/scanner.cc b/src/parsing/scanner.cc

index 5fc848f58ca843ce242a0163335683939ff8768d..224aa401d061dbf3db70f3fa3692a9b1dae1e02a 100644

--- a/src/parsing/scanner.cc

+++ b/src/parsing/scanner.cc

@@ -564,7 +564,7 @@ void Scanner::Scan() {

Advance();

if (c0_ == '-') {

Advance();

- if (c0_ == '>' && has_line_terminator_before_next_) {

+ if (c0_ == '>' && HasAnyLineTerminatorBeforeNext()) {

// For compatibility with SpiderMonkey, we skip lines that

// start with an HTML comment end '-->'.

token = SkipSingleLineComment();

« no previous file with comments | « no previous file | test/cctest/test-parsing.cc » ('j') | no next file with comments »