Recognize HTMLCloseComment after multiline comment

Recognize HTMLCloseComment after multiline comment

When the scanner finds a '-->', it's either part of an HTMLCloseComment
or a '--' followed by a '>'. Previously, only a preceding newline would
make it an HTMLCloseComment. Now, a preceding multiline comment also
makes it an HTMLCloseComment. The effect is that now the following is
not a SyntaxError:

x/*
*/-->this is now a comment

BUG=v8:5142
LOG=y

Committed: https://crrev.com/b8668fa84671a6e98b3c79fab2716b92e218c36f
Cr-Commit-Position: refs/heads/master@{#37656}

[jwolfe, 2016-07-01 22:07:37]

Description was changed from

==========
Recognize HTMLCloseComment after multiline comment

While scanning ahead and finding '-->', check for both a "real" line
terminator and a multiline comment to determine if it's an
HTMLCloseComment or a '--' followed by a '>'. The effect is that now the
following is not a SyntaxError

x/*
*/-->this is now a comment
;

BUG=v8:5142
LOG=y
==========

to

==========
Recognize HTMLCloseComment after multiline comment

While scanning ahead and finding '-->', check for both a "real" line
terminator and a multiline comment to determine if it's an
HTMLCloseComment or a '--' followed by a '>'. The effect is that now the
following is not a SyntaxError

x/*
*/-->this is now a comment
;

BUG=v8:5142
LOG=y
==========

[jwolfe, 2016-07-01 22:07:37]

jwolfe@igalia.com changed reviewers:
+ adamk@chromium.org, nikolaos@google.com

[jwolfe, 2016-07-01 22:08:26]

PTAL

[jwolfe, 2016-07-01 22:18:10]

Description was changed from

==========
Recognize HTMLCloseComment after multiline comment

While scanning ahead and finding '-->', check for both a "real" line
terminator and a multiline comment to determine if it's an
HTMLCloseComment or a '--' followed by a '>'. The effect is that now the
following is not a SyntaxError

x/*
*/-->this is now a comment
;

BUG=v8:5142
LOG=y
==========

to

==========
Recognize HTMLCloseComment after multiline comment

While scanning ahead and finding '-->', check for both a "real" line
terminator and a multiline comment to determine if it's an
HTMLCloseComment or a '--' followed by a '>'. The effect is that now the
following is not a SyntaxError

x/*
*/-->this is now a comment

BUG=v8:5142
LOG=y
==========

[adamk, 2016-07-01 22:33:17]

adamk@chromium.org changed reviewers:
+ littledan@chromium.org
- adamk@chromium.org

[adamk, 2016-07-01 22:33:18]

Punting to littledan as I don't think I'm going to get to this this afternoon
and I'll be gone next week.

[Dan Ehrenberg, 2016-07-01 23:38:18]

On 2016/07/01 22:33:18, adamk (out until june 12) wrote:
> Punting to littledan as I don't think I'm going to get to this this afternoon
> and I'll be gone next week.

lgtm

HasAnyLineTerminatorBeforeNext is a pretty awful name, but this seems like a
pretty direct rendering of the spec's grammar.

[nickie, 2016-07-04 08:27:10]

nikolaos@chromium.org changed reviewers:
+ nikolaos@chromium.org

[nickie, 2016-07-04 08:27:10]

The paragraph starting with "While" in the CL's description is a bit confusing.

https://codereview.chromium.org/2119763003/diff/20001/test/cctest/test-parsin...
File test/cctest/test-parsing.cc (right):

https://codereview.chromium.org/2119763003/diff/20001/test/cctest/test-parsin...
test/cctest/test-parsing.cc:134: "var x = 42; /* precomment\n */ --> is
eol-comment\nvar y = 37;\n",
According to the spec [1], the end of a real multi-line comment
(MultiLineComment) can be followed by an optional HTMLCloseComment.  This can
start with a sequence of not only white space, but also 
single line delimited comments (SingleLineDelimitedComment), i.e., comments of
the form /* no line terminator here */.

I am not sure if we handle this case correctly.  In any case, we should have
tests for this.  E.g.

"/* MLC \n */ /* SLDC */ --> is eol-comment\nvar y = 37;\n",
"/* MLC \n */ /* SLDC1 */ /* SLDC2 */ --> is eol-comment\nvar y = 37;\n",
"/* MLC1 \n */ /* MLC2 \n */ --> is eol-comment\nvar y = 37;\n",
"/* SLDC */ /* MLC \n */ --> is eol-comment\nvar y = 37;\n",
"/* MLC1 \n */ /* SLDC1 */ /* MLC2 \n */ /* SLDC2 */ --> is eol-comment\nvar y =
37;\n",

Also, we should possibly have tests without spaces in between the comments or
around "-->".

[1] https://tc39.github.io/ecma262/#sec-html-like-comments

[jwolfe, 2016-07-05 20:55:13]

Description was changed from

==========
Recognize HTMLCloseComment after multiline comment

While scanning ahead and finding '-->', check for both a "real" line
terminator and a multiline comment to determine if it's an
HTMLCloseComment or a '--' followed by a '>'. The effect is that now the
following is not a SyntaxError

x/*
*/-->this is now a comment

BUG=v8:5142
LOG=y
==========

to

==========
Recognize HTMLCloseComment after multiline comment

When the scanner finds a '-->', it's either part of an HTMLCloseComment
or a '--' followed by a '>'. Previously, only a preceding newline would
make it an HTMLCloseComment. Now, a preceding multiline comment also
makes it an HTMLCloseComment. The effect is that now the following is
not a SyntaxError:

x/*
*/-->this is now a comment

BUG=v8:5142
LOG=y
==========

[jwolfe, 2016-07-05 20:55:55]

updated description and added more tests.

[nickie, 2016-07-06 13:58:25]

lgtm

[jwolfe, 2016-07-06 19:12:49]

The CQ bit was checked by jwolfe@igalia.com

[jwolfe, 2016-07-06 19:12:49]

The patchset sent to the CQ was uploaded after l-g-t-m from
littledan@chromium.org
Link to the patchset: https://codereview.chromium.org/2119763003/#ps40001
(title: "add more test cases")

[commit-bot: I haz the power, 2016-07-06 19:13:00]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-06 19:28:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-06 19:28:10]

Try jobs failed on following builders:
  v8_linux64_avx2_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel_ng/buil...)
  v8_linux64_avx2_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel_ng_trig...)

[jwolfe, 2016-07-11 19:38:23]

The CQ bit was checked by jwolfe@igalia.com

[jwolfe, 2016-07-11 19:38:24]

The patchset sent to the CQ was uploaded after l-g-t-m from
nikolaos@chromium.org, littledan@chromium.org
Link to the patchset: https://codereview.chromium.org/2119763003/#ps60001
(title: "fix test/webkit/parser-xml-close-comment")

[commit-bot: I haz the power, 2016-07-11 19:38:31]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-11 20:02:36]

Description was changed from

==========
Recognize HTMLCloseComment after multiline comment

When the scanner finds a '-->', it's either part of an HTMLCloseComment
or a '--' followed by a '>'. Previously, only a preceding newline would
make it an HTMLCloseComment. Now, a preceding multiline comment also
makes it an HTMLCloseComment. The effect is that now the following is
not a SyntaxError:

x/*
*/-->this is now a comment

BUG=v8:5142
LOG=y
==========

to

==========
Recognize HTMLCloseComment after multiline comment

When the scanner finds a '-->', it's either part of an HTMLCloseComment
or a '--' followed by a '>'. Previously, only a preceding newline would
make it an HTMLCloseComment. Now, a preceding multiline comment also
makes it an HTMLCloseComment. The effect is that now the following is
not a SyntaxError:

x/*
*/-->this is now a comment

BUG=v8:5142
LOG=y
==========

[commit-bot: I haz the power, 2016-07-11 20:02:37]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-07-11 20:05:34]

Description was changed from

==========
Recognize HTMLCloseComment after multiline comment

When the scanner finds a '-->', it's either part of an HTMLCloseComment
or a '--' followed by a '>'. Previously, only a preceding newline would
make it an HTMLCloseComment. Now, a preceding multiline comment also
makes it an HTMLCloseComment. The effect is that now the following is
not a SyntaxError:

x/*
*/-->this is now a comment

BUG=v8:5142
LOG=y
==========

to

==========
Recognize HTMLCloseComment after multiline comment

When the scanner finds a '-->', it's either part of an HTMLCloseComment
or a '--' followed by a '>'. Previously, only a preceding newline would
make it an HTMLCloseComment. Now, a preceding multiline comment also
makes it an HTMLCloseComment. The effect is that now the following is
not a SyntaxError:

x/*
*/-->this is now a comment

BUG=v8:5142
LOG=y

Committed: https://crrev.com/b8668fa84671a6e98b3c79fab2716b92e218c36f
Cr-Commit-Position: refs/heads/master@{#37656}
==========

[commit-bot: I haz the power, 2016-07-11 20:05:35]

Patchset 4 (id:??) landed as
https://crrev.com/b8668fa84671a6e98b3c79fab2716b92e218c36f
Cr-Commit-Position: refs/heads/master@{#37656}