Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issue 21196006: Don't generate a shift left by one if can deoptimize on ia32 and arm and mips. (Closed)

Created:
7 years, 4 months ago by titzer
Modified:
7 years, 4 months ago
Reviewers:
Toon Verwaest
CC:
v8-dev
Visibility:
Public.

Description

Don't generate a shift left by one if can deoptimize on ia32 and arm and mips. BUG= R=verwaest@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=15958

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -3 lines) Patch
M src/arm/lithium-codegen-arm.cc View 1 chunk +3 lines, -1 line 0 comments Download
M src/ia32/lithium-codegen-ia32.cc View 1 chunk +3 lines, -1 line 0 comments Download
M src/mips/lithium-codegen-mips.cc View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
titzer
7 years, 4 months ago (2013-07-30 13:17:00 UTC) #1
Toon Verwaest
lgtm
7 years, 4 months ago (2013-07-30 13:19:19 UTC) #2
titzer
7 years, 4 months ago (2013-07-30 13:30:10 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r15958 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698