src/ia32/lithium-codegen-ia32.cc - Issue 21196006: Don't generate a shift left by one if can deoptimize on ia32 and arm and mips.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/ia32/lithium-codegen-ia32.cc

Issue 21196006: Don't generate a shift left by one if can deoptimize on ia32 and arm and mips. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/ia32/lithium-codegen-ia32.cc

diff --git a/src/ia32/lithium-codegen-ia32.cc b/src/ia32/lithium-codegen-ia32.cc

index 3ddad068bfdfc0454442a87e3fd964269d5e6298..a21a96575bf8f9c9fa8affe63aa0deca575c3cbe 100644

--- a/src/ia32/lithium-codegen-ia32.cc

+++ b/src/ia32/lithium-codegen-ia32.cc

@@ -1771,7 +1771,9 @@ void LCodeGen::DoShiftI(LShiftI* instr) {

if (shift_count != 0) {

if (instr->hydrogen_value()->representation().IsSmi() &&

instr->can_deopt()) {

- __ shl(ToRegister(left), shift_count - 1);

+ if (shift_count != 1) {

+ __ shl(ToRegister(left), shift_count - 1);

+ }

__ SmiTag(ToRegister(left));

DeoptimizeIf(overflow, instr->environment());

} else {

« no previous file with comments | « src/arm/lithium-codegen-arm.cc ('k') | src/mips/lithium-codegen-mips.cc » ('j') | no next file with comments »