Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(146)

Issue 2119513002: Fix png encoding in skia debugger (Closed)

Created:
4 years, 5 months ago by msarett
Modified:
4 years, 5 months ago
Reviewers:
Brian Osman
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 : Working #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -17 lines) Patch
M gyp/debugger.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M gyp/gmslides.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M tools/debugger/SkDrawCommand.h View 1 chunk +1 line, -1 line 0 comments Download
M tools/debugger/SkDrawCommand.cpp View 4 chunks +23 lines, -12 lines 0 comments Download
M tools/skiaserve/Request.cpp View 1 chunk +3 lines, -4 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 13 (7 generated)
msarett
Here's something finally...
4 years, 5 months ago (2016-06-30 16:11:12 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2119513002/20001
4 years, 5 months ago (2016-06-30 16:28:06 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 5 months ago (2016-06-30 16:47:47 UTC) #8
Brian Osman
lgtm
4 years, 5 months ago (2016-06-30 17:05:22 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2119513002/20001
4 years, 5 months ago (2016-06-30 17:05:57 UTC) #11
commit-bot: I haz the power
4 years, 5 months ago (2016-06-30 17:06:55 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:20001) as
https://skia.googlesource.com/skia/+/a5cf4f45bb6ecfe37058404e173e20622e6f6503

Powered by Google App Engine
This is Rietveld 408576698