Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(312)

Unified Diff: ui/views/accessibility/native_view_accessibility_mac.mm

Issue 2119413004: a11y: Exclude children of nested keyboard accessible controls from a11y tree. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase on top of 2704263002. Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/views/accessibility/native_view_accessibility_mac.mm
diff --git a/ui/views/accessibility/native_view_accessibility_mac.mm b/ui/views/accessibility/native_view_accessibility_mac.mm
index 27b1a4fc8cbba80ac0db3ba3c142a45b76d70a29..ce500585fbba0874d7f0a2c7343057012f56c92b 100644
--- a/ui/views/accessibility/native_view_accessibility_mac.mm
+++ b/ui/views/accessibility/native_view_accessibility_mac.mm
@@ -18,8 +18,13 @@ NativeViewAccessibilityMac::NativeViewAccessibilityMac(View* view)
: NativeViewAccessibility(view) {}
gfx::NativeViewAccessible NativeViewAccessibilityMac::GetParent() {
- if (view_->parent())
- return view_->parent()->GetNativeViewAccessible();
+ View* parent_view = view_->parent();
+ if (parent_view) {
+ if (NativeViewAccessibility::GetForView(parent_view)->GetData().role ==
+ ui::AX_ROLE_IGNORED)
Patti Lor 2017/02/21 03:29:17 I just inlined IsViewA11yIgnored() from native_vie
tapted 2017/02/21 06:01:12 Can this do something like gfx::NativeViewAccessi
Patti Lor 2017/02/27 05:31:04 Done, kinda - traded your GetToolkitParent() sugge
+ return GetForView(parent_view)->GetParent();
+ return parent_view->GetNativeViewAccessible();
+ }
if (view_->GetWidget())
return view_->GetWidget()->GetNativeView();

Powered by Google App Engine
This is Rietveld 408576698