a11y: Exclude children of nested keyboard accessible controls from a11y tree.

ui/views/accessibility/native_view_accessibility_mac.mm

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/views/accessibility/native_view_accessibility_mac.h"
 
 #include "ui/views/view.h"
 #include "ui/views/widget/widget.h"
 
 namespace views {
 
 // static
 NativeViewAccessibility* NativeViewAccessibility::Create(View* view) {
   return new NativeViewAccessibilityMac(view);
 }
 
 NativeViewAccessibilityMac::NativeViewAccessibilityMac(View* view)
     : NativeViewAccessibility(view) {}
 
 gfx::NativeViewAccessible NativeViewAccessibilityMac::GetParent() {
-  if (view_->parent())
-    return view_->parent()->GetNativeViewAccessible();
+  View* parent_view = view_->parent();
+  if (parent_view) {
+    if (NativeViewAccessibility::GetForView(parent_view)->GetData().role ==
+        ui::AX_ROLE_IGNORED)

[Patti Lor, 2017/02/21 03:29:17]

I just inlined IsViewA11yIgnored() from native_view_accessibility.cc here,
hopefully that's OK.

[tapted, 2017/02/21 06:01:12]

Can this do something like

gfx::NativeViewAccessible toolkit_parent =
NativeViewAccessibility::GetToolkitParent();
if (toolkit_parent)
  return toolkit_parent;

if (view_->GetWidget())
  return view_->GetWidget()->GetNativeView();

if (parent_widget_)
  return parent_widget_->GetRootView()->GetNativeViewAccessible();


(maybe this should be in that other CL...)

[Patti Lor, 2017/02/27 05:31:04]

Done, kinda - traded your GetToolkitParent() suggestion for a virtual method
that retrieves the Widget parent, since both will be adding a new method anyway.

+      return GetForView(parent_view)->GetParent();
+    return parent_view->GetNativeViewAccessible();
+  }
 
   if (view_->GetWidget())
     return view_->GetWidget()->GetNativeView();
 
   if (parent_widget_)
     return parent_widget_->GetRootView()->GetNativeViewAccessible();
 
   return nullptr;
 }
 
 }  // namespace views