ui/views/accessibility/native_view_accessibility.h - Issue 2119413004: a11y: Exclude children of nested keyboard accessible controls from a11y tree.

Unified Diff: ui/views/accessibility/native_view_accessibility.h

Issue 2119413004: a11y: Exclude children of nested keyboard accessible controls from a11y tree. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Refactor to use ui::AX_ROLE_IGNORED for excluding a11y elements from the tree instead of focusabili… Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« ui/accessibility/platform/ax_platform_node_mac.mm ('K') | « ui/accessibility/platform/ax_platform_node_mac.mm ('k') | ui/views/accessibility/native_view_accessibility.cc » ('j') | ui/views/accessibility/native_view_accessibility.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ui/views/accessibility/native_view_accessibility.h

diff --git a/ui/views/accessibility/native_view_accessibility.h b/ui/views/accessibility/native_view_accessibility.h

index f4d61b3f87919fc25799dea2ae7c171ad2c9af63..4ceec965fe7e533c1ee08e815d63a2e6eb82988c 100644

--- a/ui/views/accessibility/native_view_accessibility.h

+++ b/ui/views/accessibility/native_view_accessibility.h

@@ -5,6 +5,8 @@

#ifndef UI_VIEWS_ACCESSIBILITY_NATIVE_VIEW_ACCESSIBILITY_H_

#define UI_VIEWS_ACCESSIBILITY_NATIVE_VIEW_ACCESSIBILITY_H_

+#include <map>

#include "base/macros.h"

#include "build/build_config.h"

#include "ui/accessibility/ax_action_data.h"

@@ -36,7 +38,7 @@ class VIEWS_EXPORT NativeViewAccessibility

: public ui::AXPlatformNodeDelegate,

public WidgetObserver {

public:

- static NativeViewAccessibility* Create(View* view);

+ static NativeViewAccessibility* GetOrCreate(View* view);

gfx::NativeViewAccessible GetNativeObject();

@@ -81,6 +83,14 @@ class VIEWS_EXPORT NativeViewAccessibility

Widget* parent_widget_;

private:

+ // A static map of all the Views with an associated NativeViewAccessibility.

dmazzoni 2016/12/28 18:02:35 Perhaps: // A static map from every View to its a

Patti Lor 2017/01/11 02:01:48 Done.

+ typedef std::map<View*, NativeViewAccessibility*> NativeViewAccessibilityMap;

+ static NativeViewAccessibilityMap* GetNativeViewAccessibilityMap();

+ // Creates new platform-specific NativeViewAccessibility subclass instances.

+ static NativeViewAccessibility* CreateNewNativeViewAccessibilityImpl(

tapted 2016/12/22 02:56:36 Can we call this just `Create` still? (Also - I th

Patti Lor 2017/01/11 02:01:48 Renamed, but kept this returning a raw ptr as disc

+ View* view);

void PopulateChildWidgetVector(std::vector<Widget*>* result_child_widgets);

// We own this, but it is reference-counted on some platforms so we can't use