a11y: Exclude children of nested keyboard accessible controls from a11y tree.

ui/views/accessibility/native_view_accessibility.h

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef UI_VIEWS_ACCESSIBILITY_NATIVE_VIEW_ACCESSIBILITY_H_
 #define UI_VIEWS_ACCESSIBILITY_NATIVE_VIEW_ACCESSIBILITY_H_
 
+#include <map>
+
 #include "base/macros.h"
 #include "build/build_config.h"
 #include "ui/accessibility/ax_action_data.h"
 #include "ui/accessibility/ax_node_data.h"
 #include "ui/accessibility/platform/ax_platform_node.h"
 #include "ui/accessibility/platform/ax_platform_node_delegate.h"
 #include "ui/gfx/native_widget_types.h"
 #include "ui/views/views_export.h"
 #include "ui/views/widget/widget_observer.h"
 
@@ skipping 11 matching lines @@
 
 namespace views {
 
 class View;
 class Widget;
 
 class VIEWS_EXPORT NativeViewAccessibility
     : public ui::AXPlatformNodeDelegate,
       public WidgetObserver {
  public:
-  static NativeViewAccessibility* Create(View* view);
+  static NativeViewAccessibility* GetOrCreate(View* view);
 
   gfx::NativeViewAccessible GetNativeObject();
 
   // Call Destroy rather than deleting this, because the subclass may
   // use reference counting.
   virtual void Destroy();
 
   void NotifyAccessibilityEvent(ui::AXEvent event_type);
 
   // Focuses or unfocuses a View.
@@ skipping 24 matching lines @@
 
   // Weak. Owns this.
   View* view_;
 
   // Weak. Uses WidgetObserver to clear. This is set on the root view for
   // a widget that's owned by another widget, so we can walk back up the
   // tree.
   Widget* parent_widget_;
 
  private:
+  // A static map of all the Views with an associated NativeViewAccessibility.

[dmazzoni, 2016/12/28 18:02:35]

Perhaps:

// A static map from every View to its associated NativeViewAccessibility.

[Patti Lor, 2017/01/11 02:01:48]

Done.

+  typedef std::map<View*, NativeViewAccessibility*> NativeViewAccessibilityMap;
+  static NativeViewAccessibilityMap* GetNativeViewAccessibilityMap();
+
+  // Creates new platform-specific NativeViewAccessibility subclass instances.
+  static NativeViewAccessibility* CreateNewNativeViewAccessibilityImpl(

[tapted, 2016/12/22 02:56:36]

Can we call this just `Create` still? (Also - I think we can remove
NativeViewAccessibility::Destroy() and return a std::unique_ptr here -- see
other comments)

[Patti Lor, 2017/01/11 02:01:48]

Renamed, but kept this returning a raw ptr as discussed.

+      View* view);
+
   void PopulateChildWidgetVector(std::vector<Widget*>* result_child_widgets);
 
   // We own this, but it is reference-counted on some platforms so we can't use
   // a scoped_ptr. It is dereferenced in the destructor.
   ui::AXPlatformNode* ax_node_;
 
   ui::AXNodeData data_;
 
   DISALLOW_COPY_AND_ASSIGN(NativeViewAccessibility);
 };
 
 }  // namespace views
 
 #endif  // UI_VIEWS_ACCESSIBILITY_NATIVE_VIEW_ACCESSIBILITY_H_