Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Unified Diff: ui/views/accessibility/native_view_accessibility_unittest.cc

Issue 2119413004: a11y: Exclude children of nested keyboard accessible controls from a11y tree. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Don't ignore children if they're accessibility focusable, regardless of enabled state. Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/views/accessibility/native_view_accessibility_unittest.cc
diff --git a/ui/views/accessibility/native_view_accessibility_unittest.cc b/ui/views/accessibility/native_view_accessibility_unittest.cc
index c75ae19e1d3ce103c3c77b5b02647d47da023cb0..4633cea62dc83a57cb18ef059e0c903a9306c5fa 100644
--- a/ui/views/accessibility/native_view_accessibility_unittest.cc
+++ b/ui/views/accessibility/native_view_accessibility_unittest.cc
@@ -70,6 +70,11 @@ class NativeViewAccessibilityTest : public ViewsTestBase {
TEST_F(NativeViewAccessibilityTest, RoleShouldMatch) {
EXPECT_EQ(ui::AX_ROLE_BUTTON, button_accessibility_->GetData().role);
+#if defined(OS_MACOSX)
+ // Accessibility focusable controls on Mac are always leaf nodes, so to check
+ // the role matches here, make button unfocusable.
+ button_->SetFocusBehavior(View::FocusBehavior::NEVER);
tapted 2016/11/29 03:12:49 We can add // On Mac, the label isn't given a rol
Patti Lor 2016/11/29 23:26:18 Done.
+#endif
EXPECT_EQ(ui::AX_ROLE_STATIC_TEXT, label_accessibility_->GetData().role);
}

Powered by Google App Engine
This is Rietveld 408576698