ui/views/view.h - Issue 2119413004: a11y: Exclude children of nested keyboard accessible controls from a11y tree.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/views/view.h

Issue 2119413004: a11y: Exclude children of nested keyboard accessible controls from a11y tree. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Don't ignore children if they're accessibility focusable, regardless of enabled state. Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« ui/views/accessibility/native_view_accessibility_unittest.cc ('K') | « ui/views/accessibility/native_view_accessibility_unittest.cc ('k') | ui/views/widget/native_widget_mac_accessibility_unittest.mm » ('j') | ui/views/widget/native_widget_mac_accessibility_unittest.mm » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ui/views/view.h

diff --git a/ui/views/view.h b/ui/views/view.h

index a6811afca8a5c084b0d81d5ab375e483cc46c006..8ded0e44f49cceb5159e9510923533b0e92f8dd4 100644

--- a/ui/views/view.h

+++ b/ui/views/view.h

@@ -779,7 +779,8 @@ class VIEWS_EXPORT View : public ui::LayerDelegate,

// IMPORTANT NOTE: loops in the focus hierarchy are not supported.

void SetNextFocusableView(View* view);

- // Sets |focus_behavior| and advances focus if necessary.

+ // Gets/sets |focus_behavior|. SetFocusBehavior() advances focus if necessary.

+ FocusBehavior focus_behavior() const { return focus_behavior_; }

tapted 2016/11/29 03:12:49 I think this is OK. (although it raises the questi

Patti Lor 2016/11/29 23:26:18 Acknowledged.

void SetFocusBehavior(FocusBehavior focus_behavior);

// Returns true if this view is focusable, |enabled_| and drawn.

@@ -1154,9 +1155,6 @@ class VIEWS_EXPORT View : public ui::LayerDelegate,

// Focus ---------------------------------------------------------------------

- // Returns last set focus behavior.

- FocusBehavior focus_behavior() const { return focus_behavior_; }

// Override to be notified when focus has changed either to or from this View.

virtual void OnFocus();

virtual void OnBlur();