Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Issue 2119393003: Filter out Android system packages from Chrome OS notification settings. (Closed)

Created:
4 years, 5 months ago by hirono
Modified:
4 years, 5 months ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2785
Target Ref:
refs/pending/branch-heads/2785
Project:
chromium
Visibility:
Public.

Description

Filter out Android system packages from Chrome OS notification settings. In Android Settings application, there are no UI to disable notifications for system packages. The CL filter out system packages from Chrome OS notification settings UI as well. BUG=623436 TEST=manually tested on minnie Review-Url: https://codereview.chromium.org/2102433002 Cr-Commit-Position: refs/heads/master@{#403761} (cherry picked from commit 1f918658ca2a84d0124aaf98bd69e3755d9c61b2) Committed: https://chromium.googlesource.com/chromium/src/+/02f01a17a700421b28f488f84dabf2e69f163a57

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -8 lines) Patch
M chrome/browser/notifications/arc_application_notifier_source_chromeos.cc View 1 chunk +5 lines, -3 lines 0 comments Download
M chrome/browser/ui/app_list/arc/arc_app_list_prefs.h View 1 chunk +3 lines, -1 line 0 comments Download
M chrome/browser/ui/app_list/arc/arc_app_list_prefs.cc View 4 chunks +9 lines, -3 lines 0 comments Download
M components/arc/common/app.mojom View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 2 (1 generated)
hirono
4 years, 5 months ago (2016-07-06 09:40:08 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
02f01a17a700421b28f488f84dabf2e69f163a57.

Powered by Google App Engine
This is Rietveld 408576698