Issue 2119393003: Filter out Android system packages from Chrome OS notification settings.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2119393003: Filter out Android system packages from Chrome OS notification settings. (Closed)

Created:
4 years, 5 months ago by hirono

Modified:
4 years, 5 months ago

Reviewers:

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@2785

Target Ref:
refs/pending/branch-heads/2785

Project:
chromium

Visibility:
Public.

More Reviews

Description

Filter out Android system packages from Chrome OS notification settings. In Android Settings application, there are no UI to disable notifications for system packages. The CL filter out system packages from Chrome OS notification settings UI as well. BUG=623436 TEST=manually tested on minnie Review-Url: https://codereview.chromium.org/2102433002 Cr-Commit-Position: refs/heads/master@{#403761} (cherry picked from commit 1f918658ca2a84d0124aaf98bd69e3755d9c61b2) Committed: https://chromium.googlesource.com/chromium/src/+/02f01a17a700421b28f488f84dabf2e69f163a57

Patch Set 1 #

Created: 4 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+19 lines, -8 lines)			Patch
M	chrome/browser/notifications/arc_application_notifier_source_chromeos.cc	View	1 chunk	+5 lines, -3 lines	0 comments	Download
M	chrome/browser/ui/app_list/arc/arc_app_list_prefs.h	View	1 chunk	+3 lines, -1 line	0 comments	Download
M	chrome/browser/ui/app_list/arc/arc_app_list_prefs.cc	View	4 chunks	+9 lines, -3 lines	0 comments	Download
M	components/arc/common/app.mojom	View	2 chunks	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

hirono

4 years, 5 months ago (2016-07-06 09:40:08 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
02f01a17a700421b28f488f84dabf2e69f163a57.

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages