Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1769)

Unified Diff: chrome/browser/notifications/arc_application_notifier_source_chromeos.cc

Issue 2119393003: Filter out Android system packages from Chrome OS notification settings. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@2785
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/ui/app_list/arc/arc_app_list_prefs.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/notifications/arc_application_notifier_source_chromeos.cc
diff --git a/chrome/browser/notifications/arc_application_notifier_source_chromeos.cc b/chrome/browser/notifications/arc_application_notifier_source_chromeos.cc
index 108a74cbf30dd5a7d23c7812afce7f7e3cfcd6a6..c9236d142e23a85b82299f909788b615f6d9e96d 100644
--- a/chrome/browser/notifications/arc_application_notifier_source_chromeos.cc
+++ b/chrome/browser/notifications/arc_application_notifier_source_chromeos.cc
@@ -46,10 +46,12 @@ ArcApplicationNotifierSourceChromeOS::GetNotifierList(Profile* profile) {
for (const std::string& app_id : app_ids) {
const auto app = app_list->GetApp(app_id);
- if (!app)
- continue;
// Handle packages having multiple launcher activities.
- if (package_to_app_ids_.count(app->package_name))
+ if (!app || package_to_app_ids_.count(app->package_name))
+ continue;
+
+ const auto package = app_list->GetPackage(app->package_name);
+ if (!package || package->system)
continue;
// Load icons for notifier.
« no previous file with comments | « no previous file | chrome/browser/ui/app_list/arc/arc_app_list_prefs.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698