chrome/android/java/src/org/chromium/chrome/browser/media/ui/MediaSessionTabHelper.java - Issue 2119353003: Removing CustomLayout media notification logic

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/media/ui/MediaSessionTabHelper.java

Issue 2119353003: Removing CustomLayout media notification logic (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Review comments Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/media/ui/MediaNotificationManager.java ('k') | chrome/android/javatests/src/org/chromium/chrome/browser/media/ui/NotificationTitleUpdatedTest.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/media/ui/MediaSessionTabHelper.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/media/ui/MediaSessionTabHelper.java b/chrome/android/java/src/org/chromium/chrome/browser/media/ui/MediaSessionTabHelper.java

index 143afe85344b5624e90d5dd046454ae70fb2b915..a1f335d2890420280d3b1e2753edd3d79f852b19 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/media/ui/MediaSessionTabHelper.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/media/ui/MediaSessionTabHelper.java

@@ -13,7 +13,6 @@ import android.text.TextUtils;

import org.chromium.base.ContextUtils;

import org.chromium.base.Log;

import org.chromium.chrome.R;

-import org.chromium.chrome.browser.ChromeFeatureList;

import org.chromium.chrome.browser.metrics.MediaNotificationUma;

import org.chromium.chrome.browser.metrics.MediaSessionUMA;

import org.chromium.chrome.browser.tab.EmptyTabObserver;

@@ -170,9 +169,6 @@ public class MediaSessionTabHelper {

@Override

public void onFaviconUpdated(Tab tab, Bitmap icon) {

assert tab == mTab;

- // Don't update the large icon if using customized notification. Otherwise, the

- // lockscreen art will be the favicon.

- if (!ChromeFeatureList.isEnabled(ChromeFeatureList.MEDIA_STYLE_NOTIFICATION)) return;

if (!updateFavicon(icon)) return;