Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1156)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/media/ui/MediaNotificationManager.java

Issue 2119353003: Removing CustomLayout media notification logic (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Review comments Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/media/ui/MediaNotificationManager.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/media/ui/MediaNotificationManager.java b/chrome/android/java/src/org/chromium/chrome/browser/media/ui/MediaNotificationManager.java
index 4526b71d4eb5502e3ee73aea7860a96c896dd015..94707d07491ee6b9a05e5edb75a03c6c16fe308b 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/media/ui/MediaNotificationManager.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/media/ui/MediaNotificationManager.java
@@ -28,13 +28,9 @@ import android.support.v7.media.MediaRouter;
import android.text.TextUtils;
import android.util.SparseArray;
import android.view.KeyEvent;
-import android.view.View;
-import android.widget.RemoteViews;
-import org.chromium.base.ApiCompatibilityUtils;
import org.chromium.base.VisibleForTesting;
import org.chromium.chrome.R;
-import org.chromium.chrome.browser.ChromeFeatureList;
import org.chromium.content_public.common.MediaMetadata;
import javax.annotation.Nullable;
@@ -511,11 +507,8 @@ public class MediaNotificationManager {
updateMediaSession();
mNotificationBuilder = new NotificationCompat.Builder(mContext);
- if (ChromeFeatureList.isEnabled(ChromeFeatureList.MEDIA_STYLE_NOTIFICATION)) {
- setMediaStyleLayoutForNotificationBuilder(mNotificationBuilder);
- } else {
- setCustomLayoutForNotificationBuilder(mNotificationBuilder);
- }
+ setMediaStyleLayoutForNotificationBuilder(mNotificationBuilder);
+
mNotificationBuilder.setSmallIcon(mMediaNotificationInfo.icon);
mNotificationBuilder.setAutoCancel(false);
mNotificationBuilder.setLocalOnly(true);
@@ -657,68 +650,6 @@ public class MediaNotificationManager {
}
}
- private void setCustomLayoutForNotificationBuilder(NotificationCompat.Builder builder) {
- builder.setContent(createContentView());
- }
-
- private RemoteViews createContentView() {
- RemoteViews contentView =
- new RemoteViews(mContext.getPackageName(), R.layout.playback_notification_bar);
-
- // By default, play/pause button is the only one.
- int playPauseButtonId = R.id.button1;
- // On Android pre-L, dismissing the notification when the service is no longer in foreground
- // doesn't work. Instead, a STOP button is shown.
- if (mMediaNotificationInfo.supportsSwipeAway()
- && Build.VERSION.SDK_INT < Build.VERSION_CODES.LOLLIPOP
- || mMediaNotificationInfo.supportsStop()) {
- contentView.setOnClickPendingIntent(
- R.id.button1, createPendingIntent(ListenerService.ACTION_STOP));
- contentView.setContentDescription(R.id.button1, mStopDescription);
-
- // If the play/pause needs to be shown, it moves over to the second button from the end.
- playPauseButtonId = R.id.button2;
- }
-
- contentView.setTextViewText(R.id.title, mMediaNotificationInfo.metadata.getTitle());
- contentView.setTextViewText(R.id.status, mMediaNotificationInfo.origin);
-
- // Android doesn't badge the icons for RemoteViews automatically when
- // running the app under the Work profile.
- if (mNotificationIcon == null) {
- Drawable notificationIconDrawable =
- ApiCompatibilityUtils.getUserBadgedIcon(mContext, mMediaNotificationInfo.icon);
- mNotificationIcon = drawableToBitmap(notificationIconDrawable);
- }
-
- if (mNotificationIcon != null) {
- contentView.setImageViewBitmap(R.id.icon, mNotificationIcon);
- } else {
- contentView.setImageViewResource(R.id.icon, mMediaNotificationInfo.icon);
- }
-
- if (mMediaNotificationInfo.supportsPlayPause()) {
- if (mMediaNotificationInfo.isPaused) {
- contentView.setImageViewResource(playPauseButtonId, R.drawable.ic_vidcontrol_play);
- contentView.setContentDescription(playPauseButtonId, mPlayDescription);
- contentView.setOnClickPendingIntent(
- playPauseButtonId, createPendingIntent(ListenerService.ACTION_PLAY));
- } else {
- // If we're here, the notification supports play/pause button and is playing.
- contentView.setImageViewResource(playPauseButtonId, R.drawable.ic_vidcontrol_pause);
- contentView.setContentDescription(playPauseButtonId, mPauseDescription);
- contentView.setOnClickPendingIntent(
- playPauseButtonId, createPendingIntent(ListenerService.ACTION_PAUSE));
- }
-
- contentView.setViewVisibility(playPauseButtonId, View.VISIBLE);
- } else {
- contentView.setViewVisibility(playPauseButtonId, View.GONE);
- }
-
- return contentView;
- }
-
private Bitmap drawableToBitmap(Drawable drawable) {
if (!(drawable instanceof BitmapDrawable)) return null;

Powered by Google App Engine
This is Rietveld 408576698