Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2119233003: Adding capture unittests to webcam-equipped WebRTC bots. (Closed)

Created:
4 years, 5 months ago by phoglund_chromium
Modified:
4 years, 4 months ago
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org, ehmaldonado_chromium
Base URL:
https://chromium.googlesource.com/chromium/tools/build.git@master
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

Adding capture unittests to webcam-equipped WebRTC bots. BUG=618718 Committed: https://chromium.googlesource.com/chromium/tools/build/+/d9b49d015428fba8ce2d85d76279c78f7df767c3

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+262 lines, -2 lines) Patch
M scripts/slave/recipe_modules/chromium_tests/chromium_webrtc.py View 1 chunk +2 lines, -2 lines 2 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_webrtc_Linux_Builder.json View 1 chunk +1 line, -0 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_webrtc_Linux_Tester.json View 1 chunk +29 lines, -0 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_webrtc_Mac_Builder.json View 1 chunk +1 line, -0 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_webrtc_Mac_Tester.json View 1 chunk +28 lines, -0 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_webrtc_Win10_Tester.json View 1 chunk +28 lines, -0 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_webrtc_Win7_Tester.json View 1 chunk +28 lines, -0 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_webrtc_Win8_Tester.json View 1 chunk +28 lines, -0 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_webrtc_Win_Builder.json View 1 chunk +1 line, -0 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_webrtc_fyi_Linux_Builder.json View 1 chunk +1 line, -0 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_webrtc_fyi_Linux_Tester.json View 1 chunk +29 lines, -0 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_webrtc_fyi_Mac_Builder.json View 1 chunk +1 line, -0 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_webrtc_fyi_Mac_Tester.json View 1 chunk +28 lines, -0 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_webrtc_fyi_Win10_Tester.json View 1 chunk +28 lines, -0 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_webrtc_fyi_Win7_Tester.json View 1 chunk +28 lines, -0 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_webrtc_fyi_Win_Builder.json View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
phoglund_chromium
Whoops, forgot about this one. Please review.
4 years, 5 months ago (2016-07-25 07:24:55 UTC) #2
ghost stip (do not use)
lgtm
4 years, 4 months ago (2016-07-25 21:41:07 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2119233003/1
4 years, 4 months ago (2016-07-29 13:35:48 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/tools/build/+/d9b49d015428fba8ce2d85d76279c78f7df767c3
4 years, 4 months ago (2016-07-29 13:43:08 UTC) #7
mcasas
https://codereview.chromium.org/2119233003/diff/1/scripts/slave/recipe_modules/chromium_tests/chromium_webrtc.py File scripts/slave/recipe_modules/chromium_tests/chromium_webrtc.py (right): https://codereview.chromium.org/2119233003/diff/1/scripts/slave/recipe_modules/chromium_tests/chromium_webrtc.py#newcode129 scripts/slave/recipe_modules/chromium_tests/chromium_webrtc.py:129: args=['--gtest_filter=VideoCaptureDeviceTest*', This --gtest_filter probably does not apply anymore since ...
4 years, 4 months ago (2016-07-29 16:09:28 UTC) #9
kjellander_chromium
4 years, 4 months ago (2016-08-01 05:41:00 UTC) #10
Message was sent while issue was closed. 
+cc ehmaldonado for another small recipe CL task

https://codereview.chromium.org/2119233003/diff/1/scripts/slave/recipe_module...
File scripts/slave/recipe_modules/chromium_tests/chromium_webrtc.py (right):

https://codereview.chromium.org/2119233003/diff/1/scripts/slave/recipe_module...
scripts/slave/recipe_modules/chromium_tests/chromium_webrtc.py:129:
args=['--gtest_filter=VideoCaptureDeviceTest*',
On 2016/07/29 16:09:28, mcasas wrote:
> This --gtest_filter probably does not apply anymore since
> the VideoCaptureDeviceTest* moved to capture_unittests.

Right, I mentioned this in some other thread.

Edward: can you make a CL to remove this entry for media_unittests?

Powered by Google App Engine
This is Rietveld 408576698