Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(191)

Unified Diff: scripts/slave/recipe_modules/chromium_tests/chromium_webrtc.py

Issue 2119233003: Adding capture unittests to webcam-equipped WebRTC bots. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | scripts/slave/recipes/chromium.expected/full_chromium_webrtc_Linux_Builder.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: scripts/slave/recipe_modules/chromium_tests/chromium_webrtc.py
diff --git a/scripts/slave/recipe_modules/chromium_tests/chromium_webrtc.py b/scripts/slave/recipe_modules/chromium_tests/chromium_webrtc.py
index 784df2dd7bd58f82ad1854f721cd3360855fbd3f..a2f270dd495b115fb4dfb02d7501ec56d4a7bd95 100644
--- a/scripts/slave/recipe_modules/chromium_tests/chromium_webrtc.py
+++ b/scripts/slave/recipe_modules/chromium_tests/chromium_webrtc.py
@@ -116,14 +116,14 @@ def TestSpec(parent_builder, perf_id, platform, target_bits,
# These tests needs --test-launcher-jobs=1 since some of them are
# not able to run in parallel (due to the usage of the
# peerconnection server).
- # TODO(phoglund): increasing timeout for the HD video quality test.
- # The original timeout was 300000. See http://crbug.com/476865.
args=['--gtest_filter=WebRtc*:Webrtc*:TabCapture*:*MediaStream*',
'--run-manual', '--ui-test-action-max-timeout=350000',
'--test-launcher-jobs=1',
'--test-launcher-bot-mode',
'--test-launcher-print-test-stdio=always'],
perf_id=perf_id),
+ # Run capture unittests as well since our bots have real webcams.
+ WebRTCTest('capture_unittests'),
WebRTCTest('content_unittests'),
WebRTCTest('media_unittests',
args=['--gtest_filter=VideoCaptureDeviceTest*',
mcasas 2016/07/29 16:09:28 This --gtest_filter probably does not apply anymor
kjellander_chromium 2016/08/01 05:41:00 Right, I mentioned this in some other thread. Edw
« no previous file with comments | « no previous file | scripts/slave/recipes/chromium.expected/full_chromium_webrtc_Linux_Builder.json » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698